Skip to content

[SYCL][Driver] Change default SYCL version to be 2020 #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

cperkinsintel
Copy link
Contributor

Support for sycl-std=2020 was added in an earlier PR( #2259 ) but the default SYCL version was left alone. Now we are changing the FE so that if not otherwise specified sycl-std=2020 is elected as the default.

Signed-off-by: Chris Perkins [email protected]

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanovvlad
Copy link
Contributor

/summary:run

1 similar comment
@romanovvlad
Copy link
Contributor

/summary:run

@keryell
Copy link
Contributor

keryell commented Sep 1, 2020

Great achievement! It looks like this is the first SYCL implementation aiming at the SYCL 2020 specification.

@bader bader changed the title changing default SYCL version to be 2020 [SYCL][Driver] Change default SYCL version to be 2020 Sep 2, 2020
@bader
Copy link
Contributor

bader commented Sep 2, 2020

/summary:run

@bader
Copy link
Contributor

bader commented Sep 3, 2020

@cperkinsintel, this change breaks SYCL-1.2.1 conformance test suite.
I've created a PR to fix the problem - KhronosGroup/SYCL-CTS#57.
Could you check if "fixed" test_header passes with your branch, please?
If so, I'd like to commit the CTS PR first to avoid regressions.

@cperkinsintel
Copy link
Contributor Author

@bader - Done. It passes.

I have my build with SYCL 2020 as the default, and your latest in the conformance tests, and made and ran the test_header test.

It outputs CL_SYCL_LANGUAGE_VERSION = 121 as part of the test, which looks correct.

S$ python runtests.py -b build/bin/test_header -d opencl_cpu -p intel
--- header_test
  . CL_SYCL_LANGUAGE_VERSION = 121
  - pass
 
 1 tests ran in total
  - passed : 1
  - failed : 0
  - skipped: 0
  = 100% pass rate
chrisper@scsel-cfl-10:/iusers/cperkins/sycl_workspace/SYCL-CTS$ git log
commit 856f9a2a63bedc2c72c4ffb2ae745b0657d7aa2d (HEAD -> SYCL-1.2.1/master, origin/SYCL-1.2.1/master, origin/HEAD)
Author: Alexey Bader <[email protected]>
Date:   Thu Sep 3 17:58:38 2020 +0300

    Specify SYCL standard version for Intel implementation (#57)
    
    Intel's implementation is about to switch default SYCL version to
    SYCL-2020 and it will be a breaking change for test_header, which checks
    if `CL_SYCL_LANGUAGE_VERSION` macro is defined by the compiler.

@bader bader merged commit 67acf81 into intel:sycl Sep 3, 2020
@cperkinsintel cperkinsintel deleted the cperkins-sycl-2020-default branch September 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants