API changes based upon the feedback from users #2476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbobrovs
previously approved these changes
Sep 16, 2020
cmc-rep
force-pushed
the
cmc-rep-change2
branch
from
bcd3515 to
90556af
Compare
slm_init is a shell function without implementation. During LowerESIMD, we just extract the input size constant as the slm-size. That is why it is marked SYCL_EXTERNAL. I have changed esimd_fence attribute from "inline" to "ESIMD_INLINE" |
kbobrovs
previously approved these changes
Sep 16, 2020
|
@cmc-rep Could you please fix regression found by pre-commit testing? |
Signed-off-by: Gang Y Chen <[email protected]>
cmc-rep
force-pushed
the
cmc-rep-change2
branch
from
90556af to
299ba99
Compare
vladimirlaz
approved these changes
Sep 21, 2020
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[L0] Fix Event Memory Leak due to no destroy on delete
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0] Fix Event Memory Leak due to no destroy on delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen [email protected]