-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Add properties argument to piMemBufferCreate #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romanovvlad
merged 7 commits into
intel:sycl
from
MrSidims:private/MrSidims/createBufWithProperties
Oct 26, 2020
Merged
[SYCL] Add properties argument to piMemBufferCreate #2666
romanovvlad
merged 7 commits into
intel:sycl
from
MrSidims:private/MrSidims/createBufWithProperties
Oct 26, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to pass property list to lower APIs. This patch adds support for cl_intel_create_buffer_with_properties extension, that adds clCreateBufferWithPropertiesINTEL API function for OpenCL 1.0 with itself is ported from OpenCL 3.0. https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_create_buffer_with_properties.html Signed-off-by: Dmitry Sidorov <[email protected]>
Signed-off-by: Dmitry Sidorov <[email protected]>
Signed-off-by: Dmitry Sidorov <[email protected]>
romanovvlad
reviewed
Oct 22, 2020
Signed-off-by: Dmitry Sidorov <[email protected]>
Signed-off-by: Dmitry Sidorov <[email protected]>
romanovvlad
previously approved these changes
Oct 22, 2020
smaslov-intel
suggested changes
Oct 22, 2020
Signed-off-by: Dmitry Sidorov <[email protected]>
/summary:run |
smaslov-intel
previously approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dmitry Sidorov <[email protected]>
smaslov-intel
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to pass property list to lower APIs.
This patch adds support for cl_intel_create_buffer_with_properties
extension, that adds clCreateBufferWithPropertiesINTEL API function
for OpenCL 1.0 with itself is ported from OpenCL 3.0.
https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_create_buffer_with_properties.html
Signed-off-by: Dmitry Sidorov [email protected]