[SYCL] Don't perform early free of native kernel command group #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Kanaev <[email protected]>
|
/summary:run |
|
Going to add an enhancement. |
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
changed the title
Signed-off-by: Sergey Kanaev <[email protected]>
|
/summary:run |
Signed-off-by: Sergey Kanaev <[email protected]>
|
/summary:run |
cperkinsintel
previously approved these changes
Oct 23, 2020
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
private/s-kanaev/wa-early-free-native-kernel
branch
from
7f5299e to
5750828
Compare
cperkinsintel
previously approved these changes
Oct 23, 2020
keryell
suggested changes
Oct 23, 2020
| @@ -1724,12 +1724,18 @@ pi_result ExecCGCommand::SetKernelParamsAndLaunch( | |||
| void DispatchNativeKernel(void *Blob) { | |||
There was a problem hiding this comment.
By looking at the code I wonder why Blob could not be more carefully typed at the first place instead of all this ****** spaghetti code that gives mitigated trust in the code... :-/
| @@ -70,6 +70,7 @@ EventImplPtr Scheduler::addCG(std::unique_ptr<detail::CG> CommandGroup, | |||
| QueueImplPtr Queue) { | |||
| EventImplPtr NewEvent = nullptr; | |||
| const bool IsKernel = CommandGroup->getType() == CG::KERNEL; | |||
| const bool IsHostKernel = CommandGroup->getType() == CG::RUN_ON_HOST_INTEL; | |||
There was a problem hiding this comment.
I would like some std::variant here when C++17 lands instead of all this manual pattern matching.
|
/summary:run |
added 2 commits
October 26, 2020 14:11
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
|
/summary:run |
romanovvlad
approved these changes
Oct 26, 2020
|
@s-kanaev, please follow up separately on comments not addressed within this change. |
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[CI][Bench] Use GPU mask to match the CPU mask
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[CI][Bench] Use GPU mask to match the CPU mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.