Skip to content

[SYCL] Clang Front End Support for image classes. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

garimagu
Copy link
Contributor

Added:
Implicit types for images in opencl in Sema.cpp
Test case image_accessor.cpp that checks for the IR generated
from clang front end.
Test case accessor-targets-image.cpp that checks for image type
kernel aguments.
image_ocl_types.hpp - defines type aliases for opencl_imagexx_xx_ty based
on dimensions, access mode and access target. This is used by device
compiler, to create correct opencl types in LLVM IR.

Signed-off-by: Garima Gupta [email protected]

@garimagu garimagu requested a review from v-klochkov June 27, 2019 22:09
@garimagu garimagu force-pushed the clang_image_support branch from 225d475 to 67b4689 Compare June 28, 2019 00:10
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just an indent issue.

@bader bader self-assigned this Jun 28, 2019
Added-
 * Implicit types for images in opencl in Sema.cpp
 * Test case image_accessor.cpp that checks for the IR generated
 from clang front end.
 * Test case accessor-targets-image.cpp that checks for image type
 kernel aguments.
 * image_ocl_types.hpp - defines type aliases for opencl_imagexx_xx_ty based
on dimensions, access mode and access target. This is used by device
compiler, to create correct opencl types in LLVM IR.

Signed-off-by: Garima Gupta <[email protected]>
@garimagu garimagu force-pushed the clang_image_support branch from 67b4689 to 765a147 Compare June 28, 2019 21:19
@bader bader merged commit a5ad7a1 into intel:sycl Jul 1, 2019
vladimirlaz pushed a commit to vladimirlaz/llvm that referenced this pull request Dec 26, 2019
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants