Skip to content

[clang-offload-bundler] unification with the upstream LLVM [NFC] #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

sndmitriev
Copy link
Contributor

Unify FileHandler interfaces with the upstream LLVM.

Signed-off-by: Sergey Dmitriev [email protected]

Unify FileHandler interfaces with the upstream LLVM.

Signed-off-by: Sergey Dmitriev <[email protected]>
@Fznamznon
Copy link
Contributor

Fznamznon commented Nov 26, 2020

I believe we need a separate team of codeowners for clang-offload-bundler and clang-offload-wrapper changes.

@kbobrovs
Copy link
Contributor

Unify FileHandler interfaces with the upstream LLVM.

@sndmitriev , could you please provide a link to the upstream with corresponding patch or provide some comments what this patch does?

@sndmitriev
Copy link
Contributor Author

@kbobrovs, this is just a cleanup which does not change functionality. It makes FileHandler interface the same as in the llvm.org.

@sndmitriev sndmitriev requested a review from bader November 28, 2020 04:48
@bader
Copy link
Contributor

bader commented Nov 28, 2020

@sndmitriev, is there any reason to not contribute this patch to llorg? If not, I suggest committing to llorg instead. We regularly pull commits from llorg, so if patch lands there, it will appear eventually in sycl branch.

@sndmitriev
Copy link
Contributor Author

Do I need to do any additional changes to get this patch merged?

@bader
Copy link
Contributor

bader commented Nov 30, 2020

Do I need to do any additional changes to get this patch merged?

Could you answer the question below, please?

@sndmitriev, is there any reason to not contribute this patch to llorg? If not, I suggest committing to llorg instead. We regularly pull commits from llorg, so if patch lands there, it will appear eventually in sycl branch.

@sndmitriev
Copy link
Contributor Author

Do I need to do any additional changes to get this patch merged?

Could you answer the question below, please?

@sndmitriev, is there any reason to not contribute this patch to llorg? If not, I suggest committing to llorg instead. We regularly pull commits from llorg, so if patch lands there, it will appear eventually in sycl branch.

Sure. This patch removes differences in FileHandler interface between llorg and sycl branch that were introduced to sycl branch long time ago. FileHandler interfaces that I am removing in this patch just do not exist in llorg, so it cannot be committed to llorg.

@bader
Copy link
Contributor

bader commented Dec 1, 2020

This patch removes differences in FileHandler interface between llorg and sycl branch that were introduced to sycl branch long time ago. FileHandler interfaces that I am removing in this patch just do not exist in llorg, so it cannot be committed to llorg.

I remember comparing llorg and sycl branches before posting my question, but it looks like I did something wrong, because I didn't that difference and I can see it. Sorry for the delay.

@bader bader merged commit ebc9886 into intel:sycl Dec 1, 2020
@sndmitriev sndmitriev deleted the public/sndmitriev/bundler-cleanup branch December 22, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants