-
Notifications
You must be signed in to change notification settings - Fork 794
[clang-offload-bundler] unification with the upstream LLVM [NFC] #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unify FileHandler interfaces with the upstream LLVM. Signed-off-by: Sergey Dmitriev <[email protected]>
I believe we need a separate team of codeowners for clang-offload-bundler and clang-offload-wrapper changes. |
@sndmitriev , could you please provide a link to the upstream with corresponding patch or provide some comments what this patch does? |
@kbobrovs, this is just a cleanup which does not change functionality. It makes FileHandler interface the same as in the llvm.org. |
@sndmitriev, is there any reason to not contribute this patch to llorg? If not, I suggest committing to llorg instead. We regularly pull commits from llorg, so if patch lands there, it will appear eventually in |
Do I need to do any additional changes to get this patch merged? |
Could you answer the question below, please?
|
Sure. This patch removes differences in FileHandler interface between llorg and sycl branch that were introduced to sycl branch long time ago. FileHandler interfaces that I am removing in this patch just do not exist in llorg, so it cannot be committed to llorg. |
I remember comparing llorg and sycl branches before posting my question, but it looks like I did something wrong, because I didn't that difference and I can see it. Sorry for the delay. |
Unify FileHandler interfaces with the upstream LLVM.
Signed-off-by: Sergey Dmitriev [email protected]