[SYCL] Fix acquiring a mutex in _pi_context::finalize #3001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed crashes in ESIMD tests at the exit of _pi_context::finalize function. Unlocking not owned mutex is Undefined Behavior. Crashes occured only on Debug builds on Windows platforms when using LevelZero. I saw the following error: "unlock of unowned mutex".
bso-intel
approved these changes
Jan 8, 2021
kbobrovs
reviewed
Jan 8, 2021
| @@ -459,7 +459,7 @@ pi_result _pi_context::finalize() { | |||
| // There could be some memory that may have not been deallocated. | |||
| // For example, zeEventPool could be still alive. | |||
| std::lock_guard<std::mutex> NumEventsLiveInEventPoolGuard( | |||
| NumEventsLiveInEventPoolMutex, std::adopt_lock); | |||
| NumEventsLiveInEventPoolMutex); | |||
There was a problem hiding this comment.
This indeed looks like copy-paste error to me, and the fix looks good.
Still, I wonder how this worked before. Basically, all the tests, including non-ESIMD should have been failing the same way, as it does not seem any thread can come here holding the NumEventsLiveInEventPoolMutex. Leaving to @smaslov-intel to review/approve.
There was a problem hiding this comment.
I think it wasn't noticed earlier because it only appears on debug builds on Windows.
smaslov-intel
approved these changes
Jan 16, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jan 18, 2021
* sycl: [sycl-post-link][NFC] Extracted the code into a subroutine (intel#3042) [SYCL][NFC] Remove commented out code (intel#3029) [CODEOWNERS] Fix ownership of DPC++ tools tests (intel#3047) [SYCL][NFC] Make tests insensitive to dso_local (intel#3037) [SYCL] Fix acquiring a mutex in _pi_context::finalize (intel#3001) [SYCL] Fix various compilation warnings in plugins (intel#2979)
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jan 19, 2021
* sycl: (378 commits) [sycl-post-link][NFC] Extracted the code into a subroutine (intel#3042) [SYCL][NFC] Remove commented out code (intel#3029) [CODEOWNERS] Fix ownership of DPC++ tools tests (intel#3047) [SYCL][NFC] Make tests insensitive to dso_local (intel#3037) [SYCL] Fix acquiring a mutex in _pi_context::finalize (intel#3001) [SYCL] Fix various compilation warnings in plugins (intel#2979) [SYCL][ESIMD] Add simd class conversion ctor and operator (intel#3028) [sycl-post-link][NFC] Use range-based for loop. (intel#3033) [SYCL][NFC] Fix warning in self-build (intel#3023) [NFC] Fix sycl-post-link tests to avoid potential race (intel#3031) [SYCL][CUDA] Add missing barrier to collectives (intel#2990) [SYCL] Make Intel attributes consistent with clang attributes. (intel#3022) [SYCL] Bump SYCL minor version (intel#3026) [SYCL][Doc] Added requirement on reference to test PR in commit message (intel#3010) [SYCL] Put constant initializer list data in non-generic addr space. (intel#3005) [SYCL][L0] Fix memory leak in PiDeviceCache and ZeCommandList (intel#2974) [SYCL] Fix detection of free function calls (intel#3003) [SYCL][NFC] Clean up the builder_dir argument description (intel#3021) [SYCL][ESIMD] Fix LowerESIMD crash on a scalar fptoui LLVM instruction (intel#2699) [NFC] Remove redundant call to getMainExecutable() (intel#3018) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed crashes in ESIMD tests at the exit of _pi_context::finalize
function. Unlocking not owned mutex is Undefined Behavior.
Crashes occured only on Debug builds on Windows platforms when using
LevelZero. I saw the following error: "unlock of unowned mutex".