Skip to content

[ESIMD] Remove propagation of sycl_explicit_simd to the callees #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

DenisBakhvalov
Copy link
Contributor

We don't need to mark the ESIMD CFG since all ESIMD-specific passes will work exclusively on the ESIMD code. So, in ESIMD passes we don't have to worry about breaking other SYCL code.

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DenisBakhvalov DenisBakhvalov changed the title [ESIMD] Remove propagation of sycl_explicit_simd to the callers [ESIMD] Remove propagation of sycl_explicit_simd to the callees Feb 3, 2021
@kbobrovs
Copy link
Contributor

kbobrovs commented Feb 4, 2021

We don't need to mark the ESIMD CFG since all ESIMD-specific passes will work exclusively on the ESIMD code. So, in ESIMD passes we don't have to worry about breaking other SYCL code.

Another important reason why we no longer need sycl_explicit_simd at every function in the call graph is that we decided that callgraph traversal and SYCL-ESIMD split will now be done in sycl-post-link rather than FE.

@bader bader merged commit 18f7cae into intel:sycl Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants