-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Refactor of [[intel::private_copies()] and [[intel::max_replicates()]] attributes #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bdd51f8
[SYCL] Refactor of [[intel::private_copies()] and [[intel::max_replic…
smanna12 11d49ae
Merge remote-tracking branch 'my_remote/sycl' into RefactorAttr
smanna12 9682b76
Fix conflicts
smanna12 52309f9
Fix format issues
smanna12 1a75787
Fix errors
smanna12 a71c5b0
Merge remote-tracking branch 'my_remote/sycl' into RefactorAttr
smanna12 d0551b6
Address review comments
smanna12 352284e
Merge remote-tracking branch 'my_remote/sycl' into RefactorAttr
smanna12 b674671
Fix error
smanna12 88cebce
Address review comments
smanna12 3eb930a
Address review comments
smanna12 b803d54
Fix format issues
smanna12 32e5232
Add comments for each added tests
smanna12 dc507c3
Merge remote-tracking branch 'my_remote/sycl' into RefactorAttr
smanna12 a98f311
Update comments in test
smanna12 179852f
Update comment in test
smanna12 90f8dd5
Fix Diagnostic
smanna12 6548d63
Add FIXME comments and address review comments
smanna12 80d2f75
Update test comments
smanna12 6a6470e
address review comments
smanna12 ece75b5
Address review comments
smanna12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// RUN: %clang_cc1 -fsycl -fsycl-is-device -fsyntax-only -ast-dump -verify -pedantic %s | FileCheck %s | ||
|
||
// Test that checks global constant variable (which allows the redeclaration) since | ||
// IntelFPGAConstVar is one of the subjects listed for [[intel::max_replicates()]] attribute. | ||
|
||
// Checking of duplicate argument values. | ||
//CHECK: VarDecl{{.*}}var_max_replicates | ||
//CHECK: IntelFPGAMaxReplicatesAttr | ||
//CHECK-NEXT: ConstantExpr | ||
//CHECK-NEXT: value:{{.*}}12 | ||
//CHECK-NEXT: IntegerLiteral{{.*}}12{{$}} | ||
//CHECK: IntelFPGAMaxReplicatesAttr | ||
//CHECK-NEXT: ConstantExpr | ||
//CHECK-NEXT: value:{{.*}}12 | ||
//CHECK-NEXT: IntegerLiteral{{.*}}12{{$}} | ||
[[intel::max_replicates(12)]] extern const int var_max_replicates; | ||
[[intel::max_replicates(12)]] const int var_max_replicates = 0; // OK | ||
|
||
// Merging of different arg values. | ||
//expected-warning@+2{{attribute 'max_replicates' is already applied with different arguments}} | ||
[[intel::max_replicates(12)]] extern const int var_max_replicates_1; | ||
[[intel::max_replicates(14)]] const int var_max_replicates_1 = 0; | ||
//expected-note@-2{{previous attribute is here}} | ||
|
||
// Merging of incompatible attributes. | ||
// FIXME: Diagnostic order isn't correct, this isn't what we'd want here but | ||
// this is an upstream issue. Merge function is calling here | ||
// checkAttrMutualExclusion() function that has backwards diagnostic behavior. | ||
// This should be fixed into upstream. | ||
//expected-error@+2{{'max_replicates' and 'fpga_register' attributes are not compatible}} | ||
//expected-note@+2{{conflicting attribute is here}} | ||
[[intel::max_replicates(12)]] extern const int var_max_replicates_2; | ||
[[intel::fpga_register]] const int var_max_replicates_2 =0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.