Skip to content

[SYCL] Switch to correct name "OpenCL.DebugInfo.100" #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021
Merged

[SYCL] Switch to correct name "OpenCL.DebugInfo.100" #3625

merged 1 commit into from
Apr 29, 2021

Conversation

NikitaRudenkoIntel
Copy link
Contributor

for SPIRV debug info extension

Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me, but I wonder whether we actually have some tests for debug info in our pre-commit: we need to be sure that SPIR-V consumers in low-level runtimes has been updated to consume OpenCL.DebugInfo.100 extended instruction set.

@vladimirlaz, do you know if we have any tests with -g in our pre-commit?

@vladimirlaz
Copy link
Contributor

The change itself looks good to me, but I wonder whether we actually have some tests for debug info in our pre-commit: we need to be sure that SPIR-V consumers in low-level runtimes has been updated to consume OpenCL.DebugInfo.100 extended instruction set.

@vladimirlaz, do you know if we have any tests with -g in our pre-commit?

We do not have reliable tests in pre-commit CI. A few tests use it but coverage is not sufficient.

@MrSidims
Copy link
Contributor

/summury:run

@MrSidims
Copy link
Contributor

MrSidims commented Apr 28, 2021

We should have FPGA tests that are being compiled with -fintelfpga flag, that adds -g by default, so if this change doesn't bring regressions on such a wild hardware we can claim, that the patch was OK tested. But looks like my 'summury:run' has no affect. Or I'm just illiterate :)

@MrSidims
Copy link
Contributor

/summary:run

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz vladimirlaz merged commit 87dbcd2 into intel:sycl Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants