-
Notifications
You must be signed in to change notification settings - Fork 797
[sycl-post-link] Add device image property for assert feature #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
14d41bb
[sycl-post-link] Add device image property for assert feature
vmaksimo e0251be
Add test
vmaksimo bda11f6
Apply suggestions
vmaksimo 2b78412
Update tests and apply suggestions
vmaksimo 1930304
Re-work call graph traversal
vmaksimo fe84701
Tests update
vmaksimo edee7c9
apply suggestions
vmaksimo d860652
minor changes
vmaksimo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
llvm/test/tools/sycl-post-link/assert-property-with-split.ll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
; This test checks that the post-link tool properly generates "assert used" | ||
; property in split mode - it should include only kernels that call assertions | ||
; in their call graph. | ||
|
||
; RUN: sycl-post-link -split=auto -symbols -S %s -o %t.table | ||
; RUN: FileCheck %s -input-file=%t_0.prop | ||
|
||
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024" | ||
target triple = "spir64-unknown-linux-sycldevice" | ||
|
||
@_ZL2GV = internal addrspace(1) constant [1 x i32] [i32 42], align 4 | ||
@.str = private unnamed_addr addrspace(1) constant [2 x i8] c"0\00", align 1 | ||
@.str.1 = private unnamed_addr addrspace(1) constant [11 x i8] c"assert.cpp\00", align 1 | ||
@__PRETTY_FUNCTION__._Z3foov = private unnamed_addr addrspace(1) constant [11 x i8] c"void foo()\00", align 1 | ||
@__spirv_BuiltInGlobalInvocationId = external dso_local local_unnamed_addr addrspace(1) constant <3 x i64>, align 32 | ||
@__spirv_BuiltInLocalInvocationId = external dso_local local_unnamed_addr addrspace(1) constant <3 x i64>, align 32 | ||
@_ZL10assert_fmt = internal addrspace(2) constant [85 x i8] c"%s:%d: %s: global id: [%lu,%lu,%lu], local id: [%lu,%lu,%lu] Assertion `%s` failed.\0A\00", align 1 | ||
|
||
; CHECK: [SYCL/assert used] | ||
vmaksimo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
; CHECK: _ZTSZ4mainE11TU0_kernel0 | ||
define dso_local spir_kernel void @_ZTSZ4mainE11TU0_kernel0() #0 { | ||
entry: | ||
call spir_func void @_Z3foov() | ||
ret void | ||
} | ||
|
||
define dso_local spir_func void @_Z3foov() { | ||
entry: | ||
%a = alloca i32, align 4 | ||
%ptr = bitcast i32* %a to i32 (i32)* | ||
%call = call spir_func i32 %ptr(i32 1) | ||
%add = add nsw i32 2, %call | ||
store i32 %add, i32* %a, align 4 | ||
tail call spir_func void @__assert_fail(i8 addrspace(4)* getelementptr inbounds ([2 x i8], [2 x i8] addrspace(4)* addrspacecast ([2 x i8] addrspace(1)* @.str to [2 x i8] addrspace(4)*), i64 0, i64 0), i8 addrspace(4)* getelementptr inbounds ([11 x i8], [11 x i8] addrspace(4)* addrspacecast ([11 x i8] addrspace(1)* @.str.1 to [11 x i8] addrspace(4)*), i64 0, i64 0), i32 8, i8 addrspace(4)* getelementptr inbounds ([11 x i8], [11 x i8] addrspace(4)* addrspacecast ([11 x i8] addrspace(1)* @__PRETTY_FUNCTION__._Z3foov to [11 x i8] addrspace(4)*), i64 0, i64 0)) | ||
ret void | ||
} | ||
|
||
; CHECK-NOT: _ZTSZ4mainE11TU0_kernel1 | ||
define dso_local spir_kernel void @_ZTSZ4mainE11TU0_kernel1() #0 { | ||
entry: | ||
call spir_func void @_Z4foo1v() | ||
ret void | ||
} | ||
|
||
; Function Attrs: nounwind | ||
define dso_local spir_func void @_Z4foo1v() { | ||
entry: | ||
%a = alloca i32, align 4 | ||
store i32 2, i32* %a, align 4 | ||
ret void | ||
} | ||
|
||
; CHECK: _ZTSZ4mainE10TU1_kernel | ||
define dso_local spir_kernel void @_ZTSZ4mainE10TU1_kernel() #1 { | ||
entry: | ||
call spir_func void @_Z4foo2v() | ||
ret void | ||
} | ||
|
||
; Function Attrs: nounwind | ||
define dso_local spir_func void @_Z4foo2v() { | ||
entry: | ||
%a = alloca i32, align 4 | ||
%0 = load i32, i32 addrspace(4)* getelementptr inbounds ([1 x i32], [1 x i32] addrspace(4)* addrspacecast ([1 x i32] addrspace(1)* @_ZL2GV to [1 x i32] addrspace(4)*), i64 0, i64 0), align 4 | ||
%add = add nsw i32 4, %0 | ||
store i32 %add, i32* %a, align 4 | ||
tail call spir_func void @__assert_fail(i8 addrspace(4)* getelementptr inbounds ([2 x i8], [2 x i8] addrspace(4)* addrspacecast ([2 x i8] addrspace(1)* @.str to [2 x i8] addrspace(4)*), i64 0, i64 0), i8 addrspace(4)* getelementptr inbounds ([11 x i8], [11 x i8] addrspace(4)* addrspacecast ([11 x i8] addrspace(1)* @.str.1 to [11 x i8] addrspace(4)*), i64 0, i64 0), i32 8, i8 addrspace(4)* getelementptr inbounds ([11 x i8], [11 x i8] addrspace(4)* addrspacecast ([11 x i8] addrspace(1)* @__PRETTY_FUNCTION__._Z3foov to [11 x i8] addrspace(4)*), i64 0, i64 0)) | ||
ret void | ||
} | ||
|
||
; Function Attrs: convergent norecurse mustprogress | ||
define weak dso_local spir_func void @__assert_fail(i8 addrspace(4)* %expr, i8 addrspace(4)* %file, i32 %line, i8 addrspace(4)* %func) local_unnamed_addr { | ||
entry: | ||
%call = tail call spir_func i64 @_Z28__spirv_GlobalInvocationId_xv() | ||
%call1 = tail call spir_func i64 @_Z28__spirv_GlobalInvocationId_yv() | ||
%call2 = tail call spir_func i64 @_Z28__spirv_GlobalInvocationId_zv() | ||
%call3 = tail call spir_func i64 @_Z27__spirv_LocalInvocationId_xv() | ||
%call4 = tail call spir_func i64 @_Z27__spirv_LocalInvocationId_yv() | ||
%call5 = tail call spir_func i64 @_Z27__spirv_LocalInvocationId_zv() | ||
tail call spir_func void @__devicelib_assert_fail(i8 addrspace(4)* %expr, i8 addrspace(4)* %file, i32 %line, i8 addrspace(4)* %func, i64 %call, i64 %call1, i64 %call2, i64 %call3, i64 %call4, i64 %call5) | ||
ret void | ||
} | ||
|
||
; Function Attrs: inlinehint norecurse mustprogress | ||
declare dso_local spir_func i64 @_Z28__spirv_GlobalInvocationId_xv() local_unnamed_addr | ||
|
||
; Function Attrs: inlinehint norecurse mustprogress | ||
declare dso_local spir_func i64 @_Z28__spirv_GlobalInvocationId_yv() local_unnamed_addr | ||
|
||
; Function Attrs: inlinehint norecurse mustprogress | ||
declare dso_local spir_func i64 @_Z28__spirv_GlobalInvocationId_zv() local_unnamed_addr | ||
|
||
; Function Attrs: inlinehint norecurse mustprogress | ||
declare dso_local spir_func i64 @_Z27__spirv_LocalInvocationId_xv() local_unnamed_addr | ||
|
||
; Function Attrs: inlinehint norecurse mustprogress | ||
declare dso_local spir_func i64 @_Z27__spirv_LocalInvocationId_yv() local_unnamed_addr | ||
|
||
; Function Attrs: inlinehint norecurse mustprogress | ||
declare dso_local spir_func i64 @_Z27__spirv_LocalInvocationId_zv() local_unnamed_addr | ||
|
||
; Function Attrs: convergent norecurse mustprogress | ||
define weak dso_local spir_func void @__devicelib_assert_fail(i8 addrspace(4)* %expr, i8 addrspace(4)* %file, i32 %line, i8 addrspace(4)* %func, i64 %gid0, i64 %gid1, i64 %gid2, i64 %lid0, i64 %lid1, i64 %lid2) local_unnamed_addr { | ||
entry: | ||
%call = tail call spir_func i32 (i8 addrspace(2)*, ...) @_Z18__spirv_ocl_printfPU3AS2Kcz(i8 addrspace(2)* getelementptr inbounds ([85 x i8], [85 x i8] addrspace(2)* @_ZL10assert_fmt, i64 0, i64 0), i8 addrspace(4)* %file, i32 %line, i8 addrspace(4)* %func, i64 %gid0, i64 %gid1, i64 %gid2, i64 %lid0, i64 %lid1, i64 %lid2, i8 addrspace(4)* %expr) | ||
ret void | ||
} | ||
|
||
; Function Attrs: convergent | ||
declare dso_local spir_func i32 @_Z18__spirv_ocl_printfPU3AS2Kcz(i8 addrspace(2)*, ...) local_unnamed_addr | ||
|
||
attributes #0 = { "sycl-module-id"="TU1.cpp" } | ||
attributes #1 = { "sycl-module-id"="TU2.cpp" } | ||
vmaksimo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
!opencl.spir.version = !{!0, !0} | ||
!spirv.Source = !{!1, !1} | ||
|
||
!0 = !{i32 1, i32 2} | ||
!1 = !{i32 4, i32 100000} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.