Skip to content

Private/s kanaev/assert abort impl test #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 143 commits into from
Closed

Private/s kanaev/assert abort impl test #3999

wants to merge 143 commits into from

Conversation

s-kanaev
Copy link
Contributor

test #3767 over #3998

Sergey Kanaev added 30 commits March 31, 2021 17:07
[SYCL] [DOC] Prepare design-document for assert feature
2911ea7 
Signed-off-by: Sergey Kanaev <[email protected]>
Remove redundant file
b69a1cd 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix typo
15ea88e 
Signed-off-by: Sergey Kanaev <[email protected]>
Address some review comments. Add description of built-ins.
ca08fec 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix links
1f8d9a9 
Signed-off-by: Sergey Kanaev <[email protected]>
Clarify that assertion failure message is printed by DPCPP Runtime
2ee590c 
Signed-off-by: Sergey Kanaev <[email protected]>
Clarify that fallback assert impl is synchronous
77699a2 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix typo in level-zero ext draft
001a573 
Signed-off-by: Sergey Kanaev <[email protected]>
Address some review comments.
32b6479 
Signed-off-by: Sergey Kanaev <[email protected]>
Add exception extension
b8637c2 
Signed-off-by: Sergey Kanaev <[email protected]>
Use error-code instead of distinct exception.
b0cd85f 
Signed-off-by: Sergey Kanaev <[email protected]>
[SYCL] Add OpenCL extension for assert error code
8c03648 
Signed-off-by: Sergey Kanaev <[email protected]>
[SYCL] Add Level-Zero extension for assert error code
121c945 
Signed-off-by: Sergey Kanaev <[email protected]>
Merge branch 'private/s-kanaev/assert-ocl-l0' into private/s-kanaev/a…
13b40fd 
…ssert-abort
Remove draft files
a4b4884 
Signed-off-by: Sergey Kanaev <[email protected]>
Remove unwanted part
c06db5f 
Signed-off-by: Sergey Kanaev <[email protected]>
Merge branch 'private/s-kanaev/assert-ocl-l0' into private/s-kanaev/a…
823124a 
…ssert-abort
Add limitations on submit to same queue after exception thrown.
a99368b 
Signed-off-by: Sergey Kanaev <[email protected]>
Add format of assert message
78d7fcb 
Signed-off-by: Sergey Kanaev <[email protected]>
Clarify where kernel wrapping takes place
6882e95 
Signed-off-by: Sergey Kanaev <[email protected]>
Changes to SYCL specification
32663e0 
Signed-off-by: Sergey Kanaev <[email protected]>
Elaborate on limitations
2b84a83 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix link
423107b 
Signed-off-by: Sergey Kanaev <[email protected]>
Add sequence describing how DPCPP RT gets to know about assert failure
7611511 
Signed-off-by: Sergey Kanaev <[email protected]>
Add notes on property set usage
a31b808 
Signed-off-by: Sergey Kanaev <[email protected]>
Address comments
257054a 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix typo and format note
3f50173 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix typo
c1326aa 
Signed-off-by: Sergey Kanaev <[email protected]>
Add extension to README
5095b1a 
Signed-off-by: Sergey Kanaev <[email protected]>
Note on how property set gets to be set
5078fcc 
Signed-off-by: Sergey Kanaev <[email protected]>
Sergey Kanaev and others added 28 commits June 21, 2021 14:13
Fix style issue
6b501bb 
Signed-off-by: Sergey Kanaev <[email protected]>
Remove call to spirv printf
d6fbb25 
Signed-off-by: Sergey Kanaev <[email protected]>
Use proper naming in libdevice
52d854c 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix comment
0b66b0e 
Signed-off-by: Sergey Kanaev <[email protected]>
Enable querying device binary property set
e7ef209 
Signed-off-by: Sergey Kanaev <[email protected]>
Guard builds for CUDA target
81a1dc2 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix style issues
3448969 
Signed-off-by: Sergey Kanaev <[email protected]>
Revert "Enable querying device binary property set"
c8ec496 
This reverts commit e7ef209.

Signed-off-by: Sergey Kanaev <[email protected]>
Overcome msvc behaviour
eb4bdc7 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix message style
6cb0a43 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix style issue
9f9421b 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix build issue
9cc989a 
Signed-off-by: Sergey Kanaev <[email protected]>
Overcome msvc behaviour. pt2
7eec090 
Signed-off-by: Sergey Kanaev <[email protected]>
Move AssertInfoCopier kernel name class to detail namespace
66c816c 
Signed-off-by: Sergey Kanaev <[email protected]>
Add structure layout description
b9c39bb 
Signed-off-by: Sergey Kanaev <[email protected]>
Eliminate ABI break
f797224 
Signed-off-by: Sergey Kanaev <[email protected]>
Store assert usage info in the event instead of runtime fetching.
901fe80 
Signed-off-by: Sergey Kanaev <[email protected]>
@vmaksimo
[sycl-post-link] Fix call graph traversal for assert property generation
fcc53ea 
This patch fixes early exit on call graph traversal. Now we do not mark
all functions above as "definitely does not call assert" as we can be sure it's
true only for a reached leaf.
Use postprocessor lambda instead of storing additional data in event
0b011d3 
Signed-off-by: Sergey Kanaev <[email protected]>
Resolve style issue
2b2b897 
Signed-off-by: Sergey Kanaev <[email protected]>
@vmaksimo
minor fix
269539d
Reuse assert info buffer in per-queue manner to eliminate deadlock si…
a02420d 
…tuation

Signed-off-by: Sergey Kanaev <[email protected]>
Merge remote-tracking branch 'vmaksimo/fix_assert_property' into priv…
9cbba46 
…ate/s-kanaev/assert-abort-impl-test
Only append copier kernel and host-task after kernels which use assert
bd5405d 
Signed-off-by: Sergey Kanaev <[email protected]>
Fix symbols dump test
8b0b8fd 
Signed-off-by: Sergey Kanaev <[email protected]>
Merge branch 'private/s-kanaev/assert-abort-impl' into private/s-kana…
1af8196 
…ev/assert-abort-impl-test
Don't emit assert post-processing for host
c8d753c 
Signed-off-by: Sergey Kanaev <[email protected]>
Merge remote-tracking branch 'public/sycl' into private/s-kanaev/asse…
9580f02 
…rt-abort-impl-test
@s-kanaev s-kanaev closed this Jun 29, 2021
@s-kanaev s-kanaev deleted the private/s-kanaev/assert-abort-impl-test branch June 29, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-kanaev @dm-vodopyanov @vmaksimo