Skip to content

[XPTI][SYCL] Fix Windows build issue #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[XPTI][SYCL] Fix Windows build issue #4143

wants to merge 2 commits into from

Conversation

s-kanaev
Copy link
Contributor

No description provided.

[SYCL] Fix Windows build issue
bbf4ab9 
Signed-off-by: Sergey Kanaev <[email protected]>
@s-kanaev s-kanaev requested a review from a team as a code owner July 19, 2021 16:41
alexbatashev
alexbatashev reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this is requred and why CI didn’t catch it?

Fix style issue
fcf085e 
Signed-off-by: Sergey Kanaev <[email protected]>
@s-kanaev s-kanaev changed the title [SYCL] Fix Windows build issue [XPTI][SYCL] Fix Windows build issue Jul 19, 2021
@bader
Copy link
Contributor

bader commented Jul 19, 2021

FYI, I reverted the patch introduced Windows build issue, so I believe this patch is not needed anymore.

@alexbatashev
Copy link
Contributor

@s-kanaev suggest closing this in favor of #4148, which contains the correct fix

@bader bader closed this Jul 20, 2021
@s-kanaev s-kanaev deleted the fix-build branch July 20, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev left review comments

@v-klochkov v-klochkov Awaiting requested review from v-klochkov

@bader bader Awaiting requested review from bader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-kanaev @bader @alexbatashev