Skip to content

[SYCL] Refactor search of eliminated args mask for kernels #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mlychkov
Copy link
Contributor

Search of eliminated agrs masks in some cases fails even for kernels
built with program manager API (for example for result of linkage of
kernel bundle programs).
Try to find an eliminated args mask within all masks by kernel name
if its native program isn't found in ProgramManager.

Signed-off-by: Mikhail Lychkov [email protected]

Search of eliminated agrs masks in some cases fails even for kernels
built with program manager API (for example for result of linkage of
kernel bundle programs).
Try to find an eliminated args mask within all masks by kernel name
if its native program isn't found in ProgramManager.

Signed-off-by: Mikhail Lychkov <[email protected]>
@mlychkov mlychkov requested a review from a team as a code owner August 26, 2021 05:17
Signed-off-by: Mikhail Lychkov <[email protected]>
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Comment on lines +164 to +166
MockHandler MockCGH(QueueImpl);
MockCGH.use_kernel_bundle(ExecBundle);
MockCGH.single_task<EAMTestKernel>([] {}); // Actual kernel does not matter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify why MockHandler is needed here? Why can't we work with the kernel bundle built on L157? Or is that needed to recreate the use-case this patch is fixing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used to utilize its functions use_kernel_bundle and single_task<>. I wouldn't want to duplicate code of handler class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood your question. Yes, it is used to recreate the use-case that is fixed by this patch.

Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit dc97f48 into intel:sycl Sep 1, 2021
dm-vodopyanov added a commit to dm-vodopyanov/llvm that referenced this pull request Sep 1, 2021
bader pushed a commit that referenced this pull request Sep 2, 2021
@mlychkov mlychkov deleted the private/mlychkov/fix_kernel_bundle_link_2 branch September 2, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants