-
Notifications
You must be signed in to change notification settings - Fork 797
[SYCL] Refactor search of eliminated args mask for kernels #4407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Refactor search of eliminated args mask for kernels #4407
Conversation
Search of eliminated agrs masks in some cases fails even for kernels built with program manager API (for example for result of linkage of kernel bundle programs). Try to find an eliminated args mask within all masks by kernel name if its native program isn't found in ProgramManager. Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
MockHandler MockCGH(QueueImpl); | ||
MockCGH.use_kernel_bundle(ExecBundle); | ||
MockCGH.single_task<EAMTestKernel>([] {}); // Actual kernel does not matter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify why MockHandler
is needed here? Why can't we work with the kernel bundle built on L157? Or is that needed to recreate the use-case this patch is fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used to utilize its functions use_kernel_bundle and single_task<>. I wouldn't want to duplicate code of handler class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood your question. Yes, it is used to recreate the use-case that is fixed by this patch.
Signed-off-by: Mikhail Lychkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Search of eliminated agrs masks in some cases fails even for kernels
built with program manager API (for example for result of linkage of
kernel bundle programs).
Try to find an eliminated args mask within all masks by kernel name
if its native program isn't found in ProgramManager.
Signed-off-by: Mikhail Lychkov [email protected]