[SYCL][ESIMD] Add support for esimd_trunc function #4624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Dmitriev <[email protected]>
sndmitriev
requested review from
DenisBakhvalov and
kychendev
as code owners
kbobrovs
reviewed
Sep 25, 2021
| @@ -1914,6 +1914,17 @@ ESIMD_INLINE RT esimd_ceil(const float &src0, const uint flags = 0) { | |||
| return esimd_rndu<RT, 1U>(src0, flags); | |||
| } | |||
|
|
|||
| template <typename RT, int SZ> | |||
There was a problem hiding this comment.
please add doxygen comments
|
@sndmitriev, please also add a E2E test to https://github.com/intel/llvm-test-suite/tree/intel/SYCL/ESIMD and add a link here. (removed my other note about LowerESIMD.cpp, as no changes are needed there) |
Link to the test suite's PR - intel/llvm-test-suite#477. I guess it won't pass testing because this PR has not been merged yet. |
kbobrovs
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Dmitriev [email protected]