Skip to content

[SYCL] Prevent unnecessary command batching in L0 plug-in #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dm-vodopyanov
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov commented Jan 17, 2022

This patch nullifies Queue->LastCommandEvent in Level Zero's
piQueueFinish as it was in _pi_event::cleanup to prevent extra batching
and performance drop.

Thus patch nullifies Queue->LastCommandEvent in Level Zero's
piQueueFinish as it was in _pi_event::cleanup to prevent extra batching
and performance drop.
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner January 17, 2022 17:31
@smaslov-intel
Copy link
Contributor

/summary:run

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT, but I requested a /summary:run

@bader
Copy link
Contributor

bader commented Jan 18, 2022

@dm-vodopyanov, I see three different "short" description of the change and I'd like to chose the one to use for the commit title:

  1. Nullify Queue->LastCommandEvent in L0's piQueueFinish (PR title)
  2. Prevent extra batching and performance drop (from PR description)
  3. Prevent unneeded already finished events to show up in the wait list (from code comments)

IMHO (1) might be clear only for a few people developing Level Zero plug-in.
Something like "Prevent unnecessary command batching in L0 plug-in" sounds more friendlier for the rest of us. :)
PR description already provides more detailed description for plug-in developers familiar with the code.
Please, update PR title if you agree with the proposal.

@dm-vodopyanov dm-vodopyanov changed the title [SYCL] Nullify Queue->LastCommandEvent in L0's piQueueFinish [SYCL] Prevent unnecessary command batching in L0 plug-in Jan 18, 2022
@dm-vodopyanov
Copy link
Contributor Author

@bader, thanks for the suggestion! Changed, it looks much better.

@bader bader merged commit 4d031a4 into intel:sycl Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants