[SYCL][NFC] Resolve variable name conflict with a macro #5513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
changed the title
alexbatashev
reviewed
Feb 8, 2022
sycl/include/CL/sycl/usm.hpp
Outdated
| @@ -20,133 +20,133 @@ namespace sycl { | |||
| /// | |||
| __SYCL_EXPORT void *malloc_device( | |||
| size_t size, const device &dev, const context &ctxt, | |||
| const detail::code_location CL = detail::code_location::current()); | |||
| const detail::code_location codeLoc = detail::code_location::current()); | |||
There was a problem hiding this comment.
To follow LLVM Style Guidelines
Suggested change
| const detail::code_location codeLoc = detail::code_location::current()); | |
| const detail::code_location CodeLoc = detail::code_location::current()); |
There was a problem hiding this comment.
Okay, I'll change it.
alexbatashev
approved these changes
Feb 8, 2022
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames conflicted
detail::code_locationname fromdetail::code_location CLtodetail::code_location codeLoc.It fixes #5479