-
Notifications
You must be signed in to change notification settings - Fork 797
[SYCL][Doc] Move internal design docs #5556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,13 +46,33 @@ | |
# The suffix of source filenames. | ||
source_suffix = ['.rst', '.md'] | ||
|
||
# Extensions are mostly in asciidoc which has poor support in Sphinx | ||
exclude_patterns = ['extensions/*'] | ||
exclude_patterns = [ | ||
# Extensions are mostly in asciidoc which has poor support in Sphinx. | ||
'extensions/*', | ||
|
||
# Sphinx complains about syntax errors in these files. | ||
'internal-design/DeviceLibExtensions.rst', | ||
'internal-design/SYCLPipesLoweringToSPIRV.rst', | ||
'internal-design/fpga_io_pipes_design.rst', | ||
'internal-design/Reduction_status.md' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should fix syntax errors and include these documents. @gmlueck, could you file a ticker for that issue, please? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I agree. I'll do this once we agree on the directory name. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I filed an internal bug report. |
||
] | ||
|
||
suppress_warnings = [ 'misc.highlighting_failure' ] | ||
|
||
def on_missing_reference(app, env, node, contnode): | ||
new_target = "https://github.com/intel/llvm/tree/sycl/sycl/doc/" + node['reftarget'] | ||
# Get the directory that contains the *source* file of the link. These | ||
# files are always relative to the directory containing "conf.py" | ||
# (<top>/sycl/doc). For example, the file "sycl/doc/internal-design/foo.md" | ||
# will have a directory "internal-design". | ||
refdoc_components = node['refdoc'].split('/') | ||
dirs = '/'.join(refdoc_components[:-1]) | ||
if dirs: dirs += '/' | ||
|
||
# A missing reference usually occurs when the target file of the link is | ||
# not processed by Sphinx. Compensate by creating a link that goes to the | ||
# file's location in the GitHub repo. | ||
new_target = "https://github.com/intel/llvm/tree/sycl/sycl/doc/" + dirs + \ | ||
node['reftarget'] | ||
|
||
newnode = nodes.reference('', '', internal=False, refuri=new_target) | ||
newnode.append(contnode) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to development-policies or development-guidelines ?
BKMs are something one may ignore, that's not what ABI doc is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
developer documentation as suggested by John is also ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to changing the directory names. Does everyone like the following:
sycl/doc/extensions
- Extension specificationssycl/doc/design
- Design documentssycl/doc/developer
- Developer informationPersonally, I think it's better to keep end-user documentation directly in
sycl/doc
because it is more prominent. I also think there are more likely to be external links to those documents, so there is some value to keeping them where they are.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to hear from @alexbatashev to see if he agrees. Updating all the links is kind of a pain, so I only want to do it once more. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the directories in b00236c. I also changed the titles in the Sphinx documentation in 429f2da