[SYCL] Separate cache dir for tests and move cache config logic #6286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes: * Makes each persistent device code cache test use a unique cache directory to prevent possible overlap. * Move the logic and caching of SYCL_CACHE_PERSISTENT and SYCL_CACHE_DIR to their own specializations of SYCLConfig. This removes the need for PersistentDeviceCodeCache::reparseConfig as the SYCLConfig specializations offer their own reset functionality. Signed-off-by: Larsen, Steffen <[email protected]>
v-klochkov
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
SYCL_CACHE_PERSISTENTandSYCL_CACHE_DIRto their own specializations ofSYCLConfig. This removes the need forPersistentDeviceCodeCache::reparseConfigas theSYCLConfigspecializations offer their own reset functionality.