[SYCL] Preserve filename passed to ocloc through -output #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A flag "-output_no_suffix" was added to ocloc, and enabling it prevents the tool from appending it's family name (e.g. "_Gen9core.bin") to the filename passed through the -output option. Meanwhile, clang-offload-bundler expects no suffixes with the binary image name. Enabling the option ensures that our toolchain is always able to find the image by the given name. Signed-off-by: Artem Gindinson <[email protected]>
romanovvlad
approved these changes
Sep 16, 2019
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Disable until they're fixed. See intel#641 for logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flag "-output_no_suffix" was added to ocloc, and enabling it
prevents the tool from appending it's family name (e.g. "_Gen9core.bin")
to the filename passed through the -output option.
Meanwhile, clang-offload-bundler expects no suffixes with the binary
image name. Enabling the option ensures that our toolchain is always
able to find the image by the given name.
Signed-off-by: Artem Gindinson [email protected]