[SYCL] Enable handler copy method for N to M dimensions.

[alexeyvoronov-intel]

Enabled the handler copy method to use it for cases with
mismatched dimensions of accessors.

Signed-off-by: Alexey Voronov [email protected]

[keryell]

Is this related to KhronosGroup/SYCL-Docs#23 or https://gitlab.khronos.org/sycl/Specification/issues/181 ?

[alexeyvoronov-intel]

Is this related to KhronosGroup/SYCL-Docs#23 or https://gitlab.khronos.org/sycl/Specification/issues/181 ?

I guess to https://gitlab.khronos.org/sycl/Specification/issues/181

[keryell]

And what about https://gitlab.khronos.org/sycl/Specification/issues/72 ? Is there an impact ?

[alexeyvoronov-intel]

And what about https://gitlab.khronos.org/sycl/Specification/issues/72 ? Is there an impact ?

Yes, but I think it can be handled when the specification issue is resolved.

>>> def sycl_id(id1,id2,id3,r1,r2,r3):
...     return id3 + (id2 * r3) + (id1 * r3 * r2)
...
>>> def opencl_id(id1,id2,id3,r1,r2,r3):
...     return id1 + (id2 * r1) + (id3 * r1 * r2)
...
>>> sycl_ids = []
>>> opencl_ids = []
>>> r1, r2, r3 = (2,2,2)
>>>
>>> for id1 in range(r1):
...     for id2 in range(r2):
...         for id3 in range(r3):
...             sycl_ids.append(sycl_id(id1,id2,id3,r1,r2,r3))
...             opencl_ids.append(opencl_id(id1,id2,id3,r1,r2,r3))
...
>>> print("SYCL", sycl_ids)
SYCL [0, 1, 2, 3, 4, 5, 6, 7]
>>> print("OpenCL", opencl_ids)
OpenCL [0, 4, 2, 6, 1, 5, 3, 7]

[keryell]

def sycl_id(id1,id2,id3,r1,r2,r3):
... return id3 + (id2 * r3) + (id1 * r3 * r2)

Is this PyCL/PSYCL/PySYCL/...? :-)

[keryell]

The problem I see for know is what is the semantics for it?
There is no documentation describing it, even not a comment in the implementation...

[alexeyvoronov-intel]

def sycl_id(id1,id2,id3,r1,r2,r3):
... return id3 + (id2 * r3) + (id1 * r3 * r2)

Is this PyCL/PSYCL/PySYCL/...? :-)

It's just Python, I copied the formulas from https://gitlab.khronos.org/sycl/Specification/issues/72 , and played with them a little.

[alexeyvoronov-intel]

The problem I see for know is what is the semantics for it?
There is no documentation describing it, even not a comment in the implementation...

I made this patch to unlock the update for CTS https://gitlab.khronos.org/sycl/Specification/issues/181.

I agree that there are many pitfalls that should be described in the specification. Will we impose the same restrictions as OpenCL or not. For example, code snippet of copying below and other more complex options:

accessor<char, 1, access::mode::read, access::target::constant> AccessorSrc(BufferSrc, Cgh, range<1>(400));
accessor<int32_t, 2, access::mode::write, access::target::global_buffer> AccessorDst(BufferDst, Cgh, range<2>(10));