[SYCL] Disable No RDC lit tests on Windows #7739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
mdtoguchi
approved these changes
Dec 12, 2022
| @@ -1,4 +1,6 @@ | |||
| /// test behaviors of passing a fat static lib with -fno-sycl-rdc | |||
| // UNSUPPORTED: system-windows | |||
There was a problem hiding this comment.
I think that's ok as a quick fix for now to make post-commit green, but I wonder if we need a follow-up PR with tests for the flag for Windows
There was a problem hiding this comment.
Yeah I am going to investigate the actual issue after this
Yeah I'll make a PR for an actual fix after this |
|
@AlexeySachkov Mind merging? Thanks again |
|
Thanks other Alexey :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They fail in post commit
Signed-off-by: Sarnie, Nick [email protected]