Skip to content

[SYCL] Cherry-pick llvm-spirv patch #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2023
Merged

[SYCL] Cherry-pick llvm-spirv patch #7930

merged 2 commits into from
Jan 6, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jan 5, 2023

I want to use this immediately for a bugfix. It's self contained and shouldn't affect anthing else

Original commit: KhronosGroup/SPIRV-LLVM-Translator@2439639

Signed-off-by: Sarnie, Nick [email protected]

Frontends can use the RegisterAllocMode metadata can be used to configure
the register allocation mode. Here we translate into a form that
Intel Graphics Compiler can use to actually apply the configuration.

This is only a temporary solution, we intend to introduce
an extension in the future

Signed-off-by: Sarnie, Nick <[email protected]>

Original commit: KhronosGroup/SPIRV-LLVM-Translator@2439639
@sarnex sarnex requested a review from MrSidims January 5, 2023 14:40
@sarnex sarnex marked this pull request as ready for review January 5, 2023 14:40
@sarnex sarnex requested a review from a team as a code owner January 5, 2023 14:40
@sarnex sarnex temporarily deployed to aws January 5, 2023 15:06 — with GitHub Actions Inactive
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex temporarily deployed to aws January 5, 2023 15:49 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to aws January 5, 2023 16:48 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor Author

sarnex commented Jan 6, 2023

@AlexeySachkov any feedback on this one? thanks

@sarnex
Copy link
Contributor Author

sarnex commented Jan 6, 2023

Looks like Alexey is OOO for 2 weeks

@asudarsa Mind reviewing this? It's just a cherry pick from the upstream translator with a lit test change to make it pass here with the older llvm we're using

@asudarsa asudarsa changed the title [SYCL] Chery-pick llvm-spirv patch [SYCL] Cherry-pick llvm-spirv patch Jan 6, 2023
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sarnex
Copy link
Contributor Author

sarnex commented Jan 6, 2023

@intel/llvm-gatekeepers Please merge when you get a chance, thanks

@bader bader merged commit 8269b59 into intel:sycl Jan 6, 2023
@sarnex sarnex deleted the cherrypick branch January 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants