-
Notifications
You must be signed in to change notification settings - Fork 797
[SYCL] Throw correct exception when passing unbound accessor to command #8131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Throw correct exception when passing unbound accessor to command #8131
Conversation
According to 4.7.6.9 of SYCL2020 spec, if a placeholder accessor is passed to a command without being bound to a command group, an exception should be thrown. Prior to this change, the exception was only thrown if an unbound placeholder accessor is used, not only passed. Also, prior to this change, if we passed one unbound accessor and one (or more) bound accessors to a command, the exception thrown was incorrect.
…-placeholder-accessor-throws
/verify with intel/llvm-test-suite#1549 |
Signed-off-by: Maronas, Marcos <[email protected]>
…-placeholder-accessor-throws
/verify with intel/llvm-test-suite#1549 |
…-placeholder-accessor-throws
/verify with intel/llvm-test-suite#1549 |
/verify with intel/llvm-test-suite#1549 |
Friendly ping @sergey-semenov @cperkinsintel @intel/llvm-reviewers-runtime |
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there are not test changes in this PR? There should either be a new test for a missing case this PR fixes or a change to enable previously disabled test (due to missing case)
Actually, isn't handling this right before enqueue a bit late? The specification requires a synchronous exception in this case, which we won't get if the submitted command is blocked. It would probably be better to throw this exception from |
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
/verify with intel/llvm-test-suite#1549 |
Signed-off-by: Maronas, Marcos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have objections from my side
…-placeholder-accessor-throws
According to 4.7.6.9 of SYCL2020 spec, if a placeholder accessor
is passed to a command without being bound to a command group, an
exception should be thrown. Prior to this change, the exception
was only thrown if an unbound placeholder accessor is used, not
only passed. Also, prior to this change, if we passed one unbound
accessor and one (or more) bound accessors to a command, the
exception thrown was incorrect.
Closes #3078.