[libclc][remangler] Teach the remangler to emit text #8199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most llvm / UNIX tools accept input on stdin and emit it to stdout by default. Most llvm tools also allow emitting textual assembly rather than bitcode. This isn't hugely important here as it's a build-time tool, but it does make debugging easier. As a side-effect of this change diagnostics go to stderr where they should always go.
bader
changed the title
npmiller
approved these changes
Feb 6, 2023
|
I've got some pending cleanups and fixes for the remangler, so it would be helpful to be able to rebase on top of this. Is it ready to merge? |
@ldrumm, please, ping @intel/llvm-gatekeepers team for help with merging. |
|
Failed Tests (1): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most llvm / UNIX tools accept input on stdin and emit it to stdout by default.
Most llvm tools also allow emitting textual assembly rather than bitcode. This isn't hugely important here as it's a build-time tool, but it does make debugging easier.
As a side-effect of this change diagnostics go to stderr where they should always go.