[SYCL] Properly take care of unnamed lambdas #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
requested review from
rolandschulz,
jbrodman,
erichkeane,
vmaksimo and
mkinsner
AGindinson
reviewed
Nov 13, 2019
alexbatashev
force-pushed
the
private/abatashe/unnamed_lambda
branch
from
f1719a7 to
6890eab
Compare
AGindinson
reviewed
Nov 13, 2019
alexbatashev
force-pushed
the
private/abatashe/unnamed_lambda
branch
from
6890eab to
0720a75
Compare
Why? |
|
@bader - We've not observed crashes so much as the compiler generating duplicate names and erroring out. |
alexbatashev
force-pushed
the
private/abatashe/unnamed_lambda
branch
2 times, most recently
from
57f3596 to
a7048b7
Compare
I improved wording |
|
After offline discussion with @rolandschulz I reconsidered the way to fix the problem. |
alexbatashev
force-pushed
the
private/abatashe/unnamed_lambda
branch
from
a7048b7 to
ec30361
Compare
romanovvlad
reviewed
Nov 14, 2019
rolandschulz
previously approved these changes
Nov 14, 2019
When two lambdas with the same signature but different content are submitted to queue, compiler complains about duplicate names and finishes with error. This patch introduces a more correct way to mangle lambdas. Signed-off-by: Alexander Batashev <[email protected]>
alexbatashev
force-pushed
the
private/abatashe/unnamed_lambda
branch
from
ec30361 to
4cc932c
Compare
romanovvlad
approved these changes
Nov 15, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Nov 30, 2020
Added translation of VCFCEntry kernel attribute to execution mode VectorComputeFastCompositeKernelINTEL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two lambdas with the same signature but different content are
submitted to queue, compiler complains about duplicate names and
finishes with error. This patch introduces a more correct way to mangle lambdas.
Signed-off-by: Alexander Batashev [email protected]