[SYCL][CUDA] Move base event into the device #8312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events are tied to a specific context, calling `cuEventElapsedTime` with two events created in separate contexts returns a `CUDA_ERROR_INVALID_HANDLE` error. So it really doesn't make sense to keep that on the platform, and now that we're using in the primary context and tied it to the device, it makes sense to also move the event base into the device class. This is technically not a problem right now because we only have one device per platform, but it's a bit cleaner will help towards the multi-device context work.
sergey-semenov
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events are tied to a specific context, calling
cuEventElapsedTimewith two events created in separate contexts returns aCUDA_ERROR_INVALID_HANDLEerror.So it really doesn't make sense to keep that on the platform, and now that we're using in the primary context and tied it to the device, it makes sense to also move the event base into the device class.
This is technically not a problem right now because we only have one device per platform, but it's a bit cleaner will help towards the multi-device context work.