Skip to content

[SYCL][DevOps] Switch GEN9 Linux pre-commit to fused L0/OCL task #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2023

Conversation

aelovikov-intel
Copy link
Contributor

SYCL End-to-End test spend most of the time on compilation. Running them against two targets with a single compilation can reduced the load generated in half.

SYCL End-to-End test spend most of the time on compilation. Running them
against two targets with a single compilation can reduced the load
generated in half.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner May 17, 2023 14:26
@aelovikov-intel
Copy link
Contributor Author

@@ -1,5 +1,17 @@
{
"lts": [
{
"config": "l0_ocl_gen9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it lin_intel_gen9 or just lin_gen9. I think the purpose is to test all existing back-ends at once. It might be more than ocl and l0 back-ends (e.g. host device).

@@ -1,5 +1,17 @@
{
"lts": [
{
"config": "l0_ocl_gen9",
"name": "L0/OCL GEN9 LLVM Test Suite",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "LLVM Test Suite"?

@aelovikov-intel aelovikov-intel temporarily deployed to aws May 17, 2023 15:57 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel requested a review from bader May 17, 2023 16:49
@aelovikov-intel aelovikov-intel temporarily deployed to aws May 17, 2023 16:50 — with GitHub Actions Inactive
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just one nit.

"config": "l0_ocl_gen9",
"name": "L0/OCL GEN9 LLVM Test Suite",
"config": "lin_gen9",
"name": "SYCL End-to-End tests on Intel GEN9 GPU on Linux",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we keep this name short, so it can be displayed in PR.
image

@aelovikov-intel aelovikov-intel temporarily deployed to aws May 17, 2023 17:33 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

@bader , would you agree that we can just merge it in since pre-commit CI won't test anything here?

@bader
Copy link
Contributor

bader commented May 17, 2023

@bader , would you agree that we can just merge it in since pre-commit CI won't test anything here?

You can cancel pre-commit CI checks.

@aelovikov-intel aelovikov-intel temporarily deployed to aws May 17, 2023 17:44 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel merged commit 20c1857 into intel:sycl May 17, 2023
@aelovikov-intel aelovikov-intel deleted the fused-l0-ocl-precommit branch May 17, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants