This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[net] Fix for #1507 - Default ble address #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default address was actually being set, but there were other methods being called that have been moved to the main file, and needed to be removed otherwise it caused havoc. Signed-off-by: Brian J Jones <[email protected]>
brianjjones
commented
Sep 1, 2017
| @@ -33,9 +33,6 @@ void zjs_net_config_default(void) | |||
| #ifdef CONFIG_NET_L2_BLUETOOTH | |||
| if (!net_ble_enabled) { | |||
| zjs_init_ble_address(); | |||
| ipss_init(); | |||
There was a problem hiding this comment.
These are now called in main.c:212. Calling them here causes net to hang.
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default address was actually being set, but there
were other methods being called that have been moved
to the main file, and needed to be removed otherwise it caused
havoc.
Signed-off-by: Brian J Jones [email protected]