Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

[gpio] Fix GPIO double signalling onchange with ashell #754

Closed
wants to merge 1 commit into from

Conversation

jprestwo
Copy link
Contributor

Signed-off-by: James Prestwood [email protected]

@jprestwo jprestwo force-pushed the fix-double-gpio-event branch from 676f91e to 3f7a04c Compare February 17, 2017 20:08
@brianjjones
Copy link
Contributor

While this is a totally practical option, I would prefer we use #755 instead. It gets JrS to clean up the GPIO object when jerry_cleanup occurs, which means we aren't required to keep track of all the GPIO handles. JrS will take care of it by calling the zjs_gpio_free_cb we provide jerry_set_object_native_handle.

@jprestwo
Copy link
Contributor Author

@brianjjones, I agree. This PR was a quick fix that just masks the problem. If #755 does allow JrS to free up the GPIO handle then we should use that.

@grgustaf
Copy link
Contributor

@jprestwo, I think this is no longer needed after @brianjjones's patch? If so, please close.

@jprestwo jprestwo closed this Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants