This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[gpio] Fix GPIO double signalling onchange with ashell #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprestwo
force-pushed
the
fix-double-gpio-event
branch
from
676f91e to
3f7a04c
Compare
Signed-off-by: James Prestwood <[email protected]>
|
While this is a totally practical option, I would prefer we use #755 instead. It gets JrS to clean up the GPIO object when jerry_cleanup occurs, which means we aren't required to keep track of all the GPIO handles. JrS will take care of it by calling the zjs_gpio_free_cb we provide jerry_set_object_native_handle. |
|
@brianjjones, I agree. This PR was a quick fix that just masks the problem. If #755 does allow JrS to free up the GPIO handle then we should use that. |
|
@jprestwo, I think this is no longer needed after @brianjjones's patch? If so, please close. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Prestwood [email protected]