Updated fracturedjsonjs to version 4.1.0 for friendlier comma placement #8106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments for more pleasing comma placement.
j-brooke
requested review from
psychedelicious,
blessedcoolant,
maryhipp and
hipsterusername
as code owners
github-actions
bot
added
frontend-deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The frontend metadata viewer uses fracturedjsonjs to format the JSON. There are some cases where the commas look out of place and can cause unnecessary wrapping. Updating to version 4.1.0 and setting two options fixes that.
Related Issues / Discussions
Closes #8092
QA Instructions
Open an image in the viewer, click on the info icon, and select the metadata tab. Look for the
modelproperty. It should be an object whose values are all strings (at least, that's all I've seen). If the code change worked, there should be no spaces between the strings' closing quotes and the commas that follow them. (See issue #8092 for more clarification.)Merge Plan
N/A
Checklist
What's Newcopy (if doing a release after this PR)