Button clicks not triggering on Android devices

[piersbertrand]

I am writing an application using ionic and ui-router, and hit a snag.

On Android devices (at least from 4.4 onwards) there is a problem with the click event polyfill, which means that no buttons trigger events. Ionic triggers a CustomEvent for a tap that does not contain the event.which property that is required by the ui-sref directive. I resolved this by the following snippet:

ionic.EventController = {
...
    trigger: function(eventType, data) {
      var event = new CustomEvent(eventType, { detail: data });
      event.which = 1;

The important part of this is the event.which is used by ui-router (and jquery) to determine that the created click event is a right button click.

I am pretty sure this is a fragile fix, and probably the new event should clone nearly all of the originating events properties.

[adamdbradley]

Can you post the HTML you're using. Adding event.which = 1 makes sense, but I'm not able to replicate the issue.

[piersbertrand]

It is all in quite a complicated application, and to distill the issue down to the issue might take a few days. I will post again once I have got to that point.

[ajoslin]

It sounds like a fix for ui-router, to be honest. It should switch its click directive to check if ( isBadValue(e) ) { //do nothing. It shouldn't do if ( isGoodValue(e) ) { //go }

https://github.com/angular-ui/ui-router/blob/master/src/stateDirectives.js#L90

I'll open a PR.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.