Skip to content

test(angular): add ng20 test app #30507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test(angular): add ng20 test app #30507

wants to merge 3 commits into from

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jun 23, 2025

Issue number: internal


What is the current behavior?

There are tests apps for Angular 16, 17, 18, and 19 only. Angular 20 has been released and should be included.

What is the new behavior?

  • Adds a test app for Angular 20

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 7:34pm

@@ -8,7 +8,7 @@ runs:
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular 20 requires a minimal node version of 20. I verified that version 22 works with all the Angular test apps that we support. By updating it to 22.x, renovate will be able to update it when necessary instead of keeping it pinned.

@thetaPC thetaPC marked this pull request as ready for review June 23, 2025 19:46
@thetaPC thetaPC requested a review from a team as a code owner June 23, 2025 19:46
@thetaPC thetaPC requested review from brandyscarney and ShaneK June 23, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant