Skip to content

Commit 6de28b6

Browse files
author
Jaime Arteaga
committed
Rebase and fix format
- Add changes to fix tests after [SYCL] Add Unified Runtime plugin and route to it with SYCL_PREFER_UR intel#9232 Signed-off-by: Jaime Arteaga <[email protected]>
1 parent 57134ea commit 6de28b6

16 files changed

+18
-24
lines changed

sycl/plugins/unified_runtime/pi2ur.hpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,6 @@ inline pi_result fixupInfoValueTypes(size_t ParamValueSizeUR,
426426
return PI_SUCCESS;
427427
}
428428

429-
430429
inline ur_result_t
431430
mapPIMetadataToUR(const pi_device_binary_property *pi_metadata,
432431
ur_program_metadata_t *ur_metadata) {
@@ -455,7 +454,10 @@ namespace pi2ur {
455454

456455
inline pi_result piTearDown(void *PluginParameter) {
457456
std::ignore = PluginParameter;
458-
HANDLE_ERRORS(urTearDown(nullptr));
457+
// TODO: Dont check for errors in urTearDown, since
458+
// when using Level Zero plugin, the second urTearDown
459+
// will fail as ur_loader.so has already been unloaded,
460+
urTearDown(nullptr);
459461
return PI_SUCCESS;
460462
}
461463

@@ -1379,7 +1381,6 @@ inline pi_result piextQueueGetNativeHandle(pi_queue Queue,
13791381
return PI_SUCCESS;
13801382
}
13811383

1382-
13831384
inline pi_result piextQueueGetNativeHandle2(pi_queue Queue,
13841385
pi_native_handle *NativeHandle,
13851386
int32_t *NativeHandleDesc) {
@@ -1388,7 +1389,6 @@ inline pi_result piextQueueGetNativeHandle2(pi_queue Queue,
13881389
return pi2ur::piextQueueGetNativeHandle(Queue, NativeHandle);
13891390
}
13901391

1391-
13921392
inline pi_result piQueueRelease(pi_queue Queue) {
13931393
PI_ASSERT(Queue, PI_ERROR_INVALID_QUEUE);
13941394

@@ -2920,7 +2920,6 @@ inline pi_result piextUSMEnqueueFill2D(pi_queue Queue, void *Ptr, size_t Pitch,
29202920
const pi_event *EventsWaitList,
29212921
pi_event *Event) {
29222922

2923-
29242923
auto hQueue = reinterpret_cast<ur_queue_handle_t>(Queue);
29252924
auto phEventWaitList =
29262925
reinterpret_cast<const ur_event_handle_t *>(EventsWaitList);
@@ -2931,7 +2930,6 @@ inline pi_result piextUSMEnqueueFill2D(pi_queue Queue, void *Ptr, size_t Pitch,
29312930
phEventWaitList, phEvent));
29322931

29332932
return PI_SUCCESS;
2934-
29352933
}
29362934

29372935
inline pi_result piextUSMEnqueueMemset2D(pi_queue Queue, void *Ptr,
@@ -3504,7 +3502,6 @@ inline pi_result piEnqueueEventsWait(pi_queue Queue,
35043502
return PI_SUCCESS;
35053503
}
35063504

3507-
35083505
inline pi_result
35093506
piextEnqueueReadHostPipe(pi_queue queue, pi_program program,
35103507
const char *pipe_symbol, pi_bool blocking, void *ptr,

sycl/plugins/unified_runtime/pi_unified_runtime.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,15 @@ piContextCreate(const pi_context_properties *Properties, pi_uint32 NumDevices,
8484
UserData, RetContext);
8585
}
8686

87+
__SYCL_EXPORT pi_result piContextGetInfo(pi_context Context,
88+
pi_context_info ParamName,
89+
size_t ParamValueSize,
90+
void *ParamValue,
91+
size_t *ParamValueSizeRet) {
92+
return pi2ur::piContextGetInfo(Context, ParamName, ParamValueSize, ParamValue,
93+
ParamValueSizeRet);
94+
}
95+
8796
__SYCL_EXPORT pi_result piContextRelease(pi_context Context) {
8897
return pi2ur::piContextRelease(Context);
8998
}
@@ -1045,6 +1054,7 @@ __SYCL_EXPORT pi_result piPluginInit(pi_plugin *PluginInit) {
10451054
_PI_API(piContextCreate)
10461055
_PI_API(piContextRelease)
10471056
_PI_API(piContextRetain)
1057+
_PI_API(piContextGetInfo)
10481058
_PI_API(piextContextSetExtendedDeleter)
10491059
_PI_API(piextContextGetNativeHandle)
10501060
_PI_API(piextContextCreateWithNativeHandle)

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <string.h>
1212

1313
#include "ur_level_zero.hpp"
14-
1514

1615
// Define the static class field
1716
std::mutex ZeCall::GlobalLock;

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_common.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include <unordered_map>
1717
#include <vector>
1818

19-
2019
#include <ur/ur.hpp>
2120
#include <ur_api.h>
2221
#include <ze_api.h>

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_context.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <unordered_set>
1616
#include <vector>
1717

18-
1918
#include <ur/ur.hpp>
2019
#include <ur_api.h>
2120
#include <ze_api.h>

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_device.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <unordered_map>
1616
#include <vector>
1717

18-
1918
#include <ur/ur.hpp>
2019
#include <ur_api.h>
2120
#include <ze_api.h>

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_event.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@
1111
#include <mutex>
1212
#include <string.h>
1313

14+
#include "ur_level_zero.hpp"
1415
#include "ur_level_zero_common.hpp"
1516
#include "ur_level_zero_event.hpp"
16-
#include "ur_level_zero.hpp"
17-
1817

1918
void printZeEventList(const _ur_ze_event_list_t &UrZeEventList) {
2019
urPrint(" NumEventsInWaitList %d:", UrZeEventList.Length);

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_event.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
#include <unordered_map>
1818
#include <vector>
1919

20-
2120
#include <ur/ur.hpp>
2221
#include <ur_api.h>
2322
#include <ze_api.h>

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_kernel.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "ur_level_zero_kernel.hpp"
1010
#include "ur_level_zero.hpp"
11-
1211

1312
UR_APIEXPORT ur_result_t UR_APICALL urEnqueueKernelLaunch(
1413
ur_queue_handle_t Queue, ///< [in] handle of the queue object
@@ -609,7 +608,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelSetArgPointer(
609608
///< holding the argument value. If null then argument
610609
///< value is considered null.
611610
) {
612-
UR_CALL(urKernelSetArgValue(Kernel, ArgIndex, sizeof(const void *), ArgValue));
611+
UR_CALL(
612+
urKernelSetArgValue(Kernel, ArgIndex, sizeof(const void *), ArgValue));
613613
return UR_RESULT_SUCCESS;
614614
}
615615

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_mem.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include <unordered_map>
1717
#include <vector>
1818

19-
2019
#include <ur/ur.hpp>
2120
#include <ur_api.h>
2221
#include <ze_api.h>

0 commit comments

Comments
 (0)