[SYCL] Add Unified Runtime plugin and route to it with SYCL_PREFER_UR #9232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
reviewed
Apr 27, 2023
jandres742
approved these changes
Apr 28, 2023
againull
reviewed
Apr 28, 2023
againull
reviewed
Apr 28, 2023
|
@againull , @cperkinsintel , @steffenlarsen : please review this |
|
The testing found subtle issue that there were multiple "plugin" objects representing the same backend floating around that got out-of-sync. To make the whole thing more robust I needed to wrap all uses of "plugin" with shared_ptr: f236317 |
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
|
No applicable L0 reviewers available. Trusting @jandres742 for the small related L0 backend changes. |
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 16, 2023
- Add changes to fix tests after [SYCL] Add Unified Runtime plugin and route to it with SYCL_PREFER_UR intel#9232 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
- Add changes to fix tests after [SYCL] Add Unified Runtime plugin and route to it with SYCL_PREFER_UR intel#9232 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
- Add changes to fix tests after [SYCL] Add Unified Runtime plugin and route to it with SYCL_PREFER_UR intel#9232 Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.