Start of GPIO implementation based on GPIO API #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| // type for delayed callback | ||
| typedef enum { | ||
| DELAYEDCALL_SETSPIN = 1, | ||
| } dc_type; |
There was a problem hiding this comment.
Type name should be UpperCamelCase
https://github.com/Samsung/iotjs/wiki/Coding_Style_Guideline#type-names
There was a problem hiding this comment.
yes, thank you for pointing out.
|
please review, more than a week has passed, |
* applied comments from #129 * setPin() API ready, others are blank * x86 native dummy code with setPin() for testingy, others are blank IoT.js-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
pmarcinkiew
referenced
this pull request
in pmarcinkiew/iotjs
Aug 29, 2017
support "make download ALL" for sidk_tash_wlan configuration sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoT.js-DCO-1.0-Signed-off-by: SaeHie Park [email protected]