Update JerryScript dependency #344
Conversation
| @@ -130,7 +130,7 @@ static JResult WrapEval(const char* source) { | |||
| int len2 = strlen(source); | |||
| int len3 = strlen(wrapper[1]); | |||
|
|
|||
| String code("", len1 + len2 + len3 + 1); | |||
| String code("", len1 + len2 + len3); | |||
There was a problem hiding this comment.
There is already a fix related to this issue in a pending PR (#330). As far as I can remember, it does not even need an updated jerry. I'd suggest (or ask, actually) to get that landed first.
There was a problem hiding this comment.
Sorry, I don't want to stole your credit. :) Of course I'll wait #330 to land first. This patch is currently a WIP patch, not ready for merge, but may help someone who want to use the latest version of JerryScript.
There was a problem hiding this comment.
@LaszloLango never thought so :) I pointed at that PR because it shows that the change can also be applied to current iot.js, and because that PR does a bit more than simply removing the +1 from the String constructor.
LaszloLango
force-pushed
the
jerry-update
branch
from
acfee56 to
bd88455
Compare
|
The PR is ready for review. @akiss77, I removed the changes of #330 from this PR. But that change is still needed for fresh Jerry. That should be merged first. |
|
LGTM |
IoT.js-DCO-1.0-Signed-off-by: László Langó [email protected]
LaszloLango
force-pushed
the
jerry-update
branch
from
bd88455 to
6e31123
Compare
|
Pr #330 got merged. LGTM. |
IoT.js-DCO-1.0-Signed-off-by: László Langó [email protected]