Add macros for more compact compile flag handling (warnings included)

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

Author: akosthekiss

CMakeLists.txt

@@ -240,20 +240,37 @@ project (Jerry CXX C ASM)
   set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -g -gdwarf-4")
 
  # Warnings
-  set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wall -Wextra -pedantic")
-  set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wformat-nonliteral -Winit-self -Wno-stack-protector")
-  set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wconversion -Wsign-conversion -Wformat-security")
-  set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wmissing-declarations -Wno-attributes")
-  set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wfatal-errors")
+  macro(append variable value)
+    set(${variable} "${${variable}} ${value}")
+  endmacro()
+
+  macro(add_jerry_compile_flags)
+    foreach(_flag ${ARGV})
+      append(COMPILE_FLAGS_JERRY ${_flag})
+    endforeach()
+  endmacro()
+
+  macro(add_jerry_compile_warnings)
+    foreach(_warning ${ARGV})
+      add_jerry_compile_flags(-W${_warning})
+      if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
+        add_jerry_compile_flags(-Werror=${_warning})
+      endif()
+    endforeach()
+  endmacro()
+
+  add_jerry_compile_warnings(all extra)
+  add_jerry_compile_flags(-pedantic)
+  add_jerry_compile_warnings(format-nonliteral init-self)
+  add_jerry_compile_flags(-Wno-stack-protector)
+  add_jerry_compile_warnings(conversion sign-conversion format-security)
+  add_jerry_compile_warnings(missing-declarations)
+  add_jerry_compile_flags(-Wno-attributes)
+  add_jerry_compile_flags(-Wfatal-errors)
   if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wlogical-op")
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=logical-op")
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=all -Werror=extra")
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=format-nonliteral -Werror=init-self")
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=conversion -Werror=sign-conversion -Werror=format-security")
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=missing-declarations")
+    add_jerry_compile_warnings(logical-op)
   else()
-    set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wno-nested-anon-types")
+    add_jerry_compile_flags(-Wno-nested-anon-types)
   endif()
 
  # Static build