Instantiation of Arguments object #102

ruben-ayrapetyan · 2015-05-26T19:28:15Z

Commit pack that enables instantiation of Arguments object.

Related issue: #53

egavrin · 2015-05-27T07:02:25Z

@ruben-ayrapetyan there are some tests related to Arguments in
https://github.com/Samsung/jerryscript/blob/master/tests/jerry-test-suite/unsupported_list.
Could you enable them?

egavrin · 2015-05-27T07:16:52Z

jerry-core/vm/opcodes.h

+ */
+typedef enum : idx_t
+{
+  OPCODE_SCOPE_CODE_FLAGS__NO_FLAGS                    = (0u),      /**< initializer for empty flag set */


Why double _?
Maybe OPCODE_SCOPE_CODE_FLAGS_EMPTY would be the better name?

Double _, because the value doesn't actually represent any functional flag.
So, it is a special value. To separate it from other values, I've added second _.
The syntax is also used in other places, like __COUNT in the following:

/** * Identifiers of ECMA and implementation-defined magic string constants */ typedef enum { #define ECMA_MAGIC_STRING_DEF(id, ascii_zt_string) \ id, #include "ecma-magic-strings.inc.h" #undef ECMA_MAGIC_STRING_DEF ECMA_MAGIC_STRING__COUNT /**< number of magic strings */ } ecma_magic_string_id_t;

or

ECMA_MAGIC_STRING_DEF (ECMA_MAGIC_STRING_COLON_CHAR, ":") ECMA_MAGIC_STRING_DEF (ECMA_MAGIC_STRING_COMMA_CHAR, ",") ECMA_MAGIC_STRING_DEF (ECMA_MAGIC_STRING_SPACE_CHAR, " ") ECMA_MAGIC_STRING_DEF (ECMA_MAGIC_STRING__EMPTY, "")

`OPCODE_SCOPE_CODE_FLAGS_EMPTY` would be similar to naming of other flags, so code `scope_flags = OPCODE_SCOPE_CODE_FLAGS_EMPTY;` could be read as something like "we mark that the scope's code has some 'empty' property".

I see. OPCODE_SCOPE_CODE_FLAGS__EMPTY?

I'll update.

ruben-ayrapetyan · 2015-05-27T10:58:27Z

@ruben-ayrapetyan there are some tests related to Arguments in
https://github.com/Samsung/jerryscript/blob/master/tests/jerry-test-suite/unsupported_list.
Could you enable them?

@egavrin , ok. Should the changes be placed in separate commit?

ruben-ayrapetyan · 2015-05-27T13:07:02Z

I've updated pull request:

fixed changes according to notes;
enabled tests from jerry-test-suite;
fixed an issue, revealed with enabled tests.

Please, review.

sand1k · 2015-05-27T14:05:52Z

LGTM (regarding changes in parser).

egavrin · 2015-05-27T17:32:58Z

@egavrin , ok. Should the changes be placed in separate commit?

@ruben-ayrapetyan please, add this with a separate commit to this branch.

ruben-ayrapetyan · 2015-05-27T17:51:48Z

@egavrin , I've updated pull request:

separated commit that enables jerry-test-suite's tests related to Argument object.

ruben-ayrapetyan · 2015-05-27T18:06:41Z

@egavrin , I've updated pull request:

replaced OPCODE_SCOPE_CODE_FLAGS__NO_FLAGS with OPCODE_SCOPE_CODE_FLAGS__EMPTY.

ruben-ayrapetyan · 2015-05-28T10:50:53Z

@galpeter , please, review.

galpeter · 2015-05-28T13:24:06Z

jerry-core/parser/js/opcodes-dumper.cpp

+
+void
+rewrite_scope_code_flags (opcode_counter_t scope_code_flags_oc,
+                          opcode_scope_code_flags_t scope_flags)


Missing comments on parameters and about the method.

Ok, I'll add.
Unfortunately, in the component the style was not used before.
However, maybe, it is better to update the component step by step, fixing style in it.

ruben-ayrapetyan · 2015-05-28T14:20:01Z

@galpeter , I've updated pull request according to your comments. Please, review.

galpeter · 2015-05-28T14:28:55Z

@ruben-ayrapetyan, looks good to me.

ruben-ayrapetyan · 2015-05-28T14:31:46Z

@galpeter, ok, thank you for review.

init_int -> vm_init; run_int -> vm_run_global; run_int_loop -> vm_loop; run_int_from_pos -> vm_run_from_pos; read_opcode -> vm_get_opcode. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

…e various properties of a scope; replacing 'strict mode' meta opcode with a flag in the flags set. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

…ce 'arguments' and 'eval' identifiers. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

…ect should be instantiated upon call of the function. The Arguments object is supposed to be unnecessary if function's code: - doesn't reference 'arguments' identifier; - doesn't reference 'eval' identifier (so, it doesn't perform direct call to eval). JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

…g and removing them from unsupported list. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

egavrin · 2015-05-29T06:55:42Z

OK, make push

ruben-ayrapetyan · 2015-06-02T14:24:52Z

I'm not sure how it happened, but it seems that update, adding comments to dump_scope_code_flags_for_rewrite and rewrite_scope_code_flags, was somehow lost - there are no comments in master, nor in the pull request.

I'll fix this, adding the changes through separate pull request.

ruben-ayrapetyan · 2015-06-02T14:26:07Z

The same for update, adding test function f (arguments) { ... }.

…guments object). JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

…rguments object). JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

ruben-ayrapetyan added normal ecma core Related to core ECMA functionality development Feature implementation labels May 26, 2015

ruben-ayrapetyan added this to the Core ECMA features milestone May 26, 2015

egavrin self-assigned this May 27, 2015

egavrin reviewed May 27, 2015
View reviewed changes

ruben-ayrapetyan force-pushed the Ruben-instantiate-arguments-object branch from a6bd26f to 74ac051 Compare May 27, 2015 13:02

ruben-ayrapetyan force-pushed the Ruben-instantiate-arguments-object branch 2 times, most recently from 87eda19 to f7dd511 Compare May 27, 2015 17:49

ruben-ayrapetyan force-pushed the Ruben-instantiate-arguments-object branch from f7dd511 to 297d976 Compare May 27, 2015 18:05

ILyoan mentioned this pull request May 28, 2015

Requirements from IoT.js #6

Closed

9 tasks

ruben-ayrapetyan assigned galpeter and unassigned egavrin May 28, 2015

galpeter reviewed May 28, 2015
View reviewed changes

ruben-ayrapetyan force-pushed the Ruben-instantiate-arguments-object branch 2 times, most recently from d832d9c to 193ad5e Compare May 28, 2015 14:18

ruben-ayrapetyan assigned egavrin and unassigned galpeter May 28, 2015

ruben-ayrapetyan added 7 commits May 28, 2015 19:12

Update of several 'vm' component interfaces naming.

3a9bf24

init_int -> vm_init; run_int -> vm_run_global; run_int_loop -> vm_loop; run_int_from_pos -> vm_run_from_pos; read_opcode -> vm_get_opcode. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

Fix of 'strict mode' meta type handling in opfunc_meta.

e984bc3

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

Introducing 'scope flags' opcode containing set of flags that indicat…

cb600da

…e various properties of a scope; replacing 'strict mode' meta opcode with a flag in the flags set. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

Adding scope's code flags indicating whether the scope's code referen…

b1a31c8

…ce 'arguments' and 'eval' identifiers. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

Instantiation of Arguments object.

d4537eb

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

Adding jerry-test-suite tests on Arguments object to precommit testin…

77df022

…g and removing them from unsupported list. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

ruben-ayrapetyan force-pushed the Ruben-instantiate-arguments-object branch from 193ad5e to 77df022 Compare May 28, 2015 16:13

ruben-ayrapetyan merged commit 77df022 into master May 29, 2015

ruben-ayrapetyan deleted the Ruben-instantiate-arguments-object branch May 29, 2015 08:17

galpeter mentioned this pull request May 29, 2015

Jerry Requirement - arguments jerryscript-project/iotjs#4

Closed

ruben-ayrapetyan added a commit that referenced this pull request Jun 2, 2015

Restoring lost review fixes to pull request #102 (instantiation of Ar…

19ae1fa

…guments object). JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

ruben-ayrapetyan mentioned this pull request Jun 2, 2015

Restoring lost review fixes for pull request #102 #143

Closed

ruben-ayrapetyan added a commit that referenced this pull request Jun 2, 2015

Restoring lost review fixes for pull request #102 (instantiation of A…

b5ebeee

…rguments object). JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

ruben-ayrapetyan added a commit that referenced this pull request Jun 3, 2015

Restoring lost review fixes for pull request #102 (instantiation of A…

4c10a6d

…rguments object). JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]

somang-park unassigned egavrin Nov 25, 2016

This was referenced May 17, 2020

stack-overflow in vm_loop #3750

Closed

stack-overflow in ecma_regexp_match #3753

Closed

Instantiation of Arguments object #102

Instantiation of Arguments object #102

Uh oh!

Conversation

ruben-ayrapetyan commented May 26, 2015

Uh oh!

egavrin commented May 27, 2015

Uh oh!

egavrin May 27, 2015

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan May 27, 2015

Choose a reason for hiding this comment

Uh oh!

egavrin May 27, 2015

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan May 27, 2015

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan May 27, 2015

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan commented May 27, 2015

Uh oh!

ruben-ayrapetyan commented May 27, 2015

Uh oh!

sand1k commented May 27, 2015

Uh oh!

egavrin commented May 27, 2015

Uh oh!

ruben-ayrapetyan commented May 27, 2015

Uh oh!

ruben-ayrapetyan commented May 27, 2015

Uh oh!

ruben-ayrapetyan commented May 28, 2015

Uh oh!

galpeter May 28, 2015

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan May 28, 2015

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan commented May 28, 2015

Uh oh!

galpeter commented May 28, 2015

Uh oh!

ruben-ayrapetyan commented May 28, 2015

Uh oh!

egavrin commented May 29, 2015

Uh oh!

ruben-ayrapetyan commented Jun 2, 2015

Uh oh!

ruben-ayrapetyan commented Jun 2, 2015

Uh oh!

Uh oh!