Added travis script to build and run jerryscript with zephyr #1144
Conversation
JerryScript-DCO-1.0-Signed-off-by: Sergio Martinez [email protected]
LaszloLango
added
development
| kill %1 | ||
| cat log.txt | ||
| if grep "Hi JS World!" log.txt > /dev/null; then echo -e "\n\nQapla'! (it means \"Success\" in Klingon)"; else echo -e "\n\nScript has failed"; fi | ||
| grep "Hi JS World!" log.txt > /dev/null |
There was a problem hiding this comment.
Please make this file more readable. Add some comment and empty line, break long lines where you can, etc. I'd rename this file, because it not just builds zephyr (ex.: build-and-test-zephyr-target.sh).
|
Nice work! I think we can merge it soon. |
Akromx16
force-pushed
the
wip/adrian_travis
branch
from
3deb788 to
41edab3
Compare
|
|
||
| # run the qemu executable in background using the named pipes | ||
| ./zephyr/zephyr_sdk/sysroots/i686-pokysdk-linux/usr/bin/qemu-system-i386 -m 32 \ | ||
| -cpu qemu32 -no-reboot -nographic -vga none -display none -net none -clock dynticks \ |
There was a problem hiding this comment.
I bit nitpicky, but please indent these lines. It makes it more readable.
Akromx16
force-pushed
the
wip/adrian_travis
branch
from
41edab3 to
d80b394
Compare
|
Thank you for the feedback! I didn't know the PR gets updated automatically once I push to my branch, sometimes I just wanted to push so travis could build to check if it works, without having the final release ready. I believe I should close the PR now and reopen it once I finish completly. |
|
@Akromx16, if you want to test the travis build, then you can enable travis for your own fork too. So when you push a new commit to any of your branches, travis will test it. You don't have to open a PR for that. But I think it is ok to keep this open. Let us know when it is ready for review. :) |
|
Yes, that is what I am doing, I am pushing on my own fork, it's just that the PR gets updated everytime I push, (even if sometimes it was for testing travis purposes, and not a final release). |
Akromx16
force-pushed
the
wip/adrian_travis
branch
5 times, most recently
from
5cb8ab5 to
4a90a9a
Compare
Travis will build jerryscript against zephyr and run the "test" command in the virtual console, using named pipe. The output is directed to log.txt which is then checked to see if the command was successfull. JerryScript-DCO-1.0-Signed-off-by: Adrian Moldovan [email protected]
Akromx16
force-pushed
the
wip/adrian_travis
branch
from
4a90a9a to
9b1e003
Compare
|
@LaszloLango @zherczeg I have my PR finished, with the changes that I could implement. There were some things that broke and I spend quite some time finding out what the problems were. I believe the zephyr sdk changed as well and caused my build to break (i wasn't changing the branch before so implicitly it was going to master). Thanks for all the feedback, and I will make more changes if there are needed. |
|
LGTM However, we might need help for fixing zephyr failures. |
|
Sorry for joining the conversation a bit late, I've been OoO for a longer period. I've objections, which I'd like to discuss / get answer for:
|
|
@akosthekiss @Akromx16 will go back to university soon and i am not sure he will be able to finish this PR with all those changes. Is it something you could help him with so we get this integration finish? 👯 |
This is good question I myself would like to find answer to - does jerryscript has any infrastructure to run its testsuite on an embedded target? I posted that question to the recently created mailing list: https://mail.gna.org/public/jerryscript-dev/2016-07/msg00000.html . @akosthekiss: If you could shed some light on that, it would be appreciated! |
|
@sergioamr, @Akromx16 : If nobody else beats me to it, then it's in my backlog ;-). But given concerns raised above, I guess I'd take this PR as a known-working reference, but would try to re-implement it myself trying to make as little changes to existing jerryscript CI structure as possible. My biggest concern however is it may be a bit heavy "gift" fro jerryscript project - majority of runtime here will (likely) be downloading of Zephyr dependencies, and that may skew JerryScript CI responsiveness. And of course, these dependencies need maintenance (update Zephyr SDK downlaod link, etc.) I'd personally be a bit shy to propose such addition right away, how I do it for the other projects is to set up a separate fork and update it manually. If it proves useful and maintained over some time (couple of months, half-year), then it's a good argumentation to burden upstream with it ;-). |
|
@pfalcon That is actually a very good suggestion, i didn't think on the heavy work that updating sdks and keeping it current could be for the Jerryscript project. For me to create a new repository with a new open project would also involve to go through a heavy internal process of open sourcing. That would be more work than actually keeping this code running :D |
|
I didn't get any mail from the mailing list, but I'm subscribed. Is it just me? |
Fortunately, on github, it's just a click of a "Fork" button, the only trouble then is to make sure to update to upstream regularly (and that's when you push new commits to your fork is when CI on it triggers). |
Just in case, I sent it last night (EU time). And according to the archive, it's a second message in the ML, after "hello" one last month. So, maybe check spam folder... |
Travis will build jerryscript against zephyr and run the "test" command in the virtual console, using named pipe. The output is directed to log.txt which is then checked to see if the command was successfull.
JerryScript-DCO-1.0-Signed-off-by: Adrian Moldovan [email protected]