Update jerry API #1147
Update jerry API #1147
Conversation
| * Returns whether the given jerry_value_t is null. | ||
| */ | ||
| bool | ||
| inline bool __attr_always_inline___ |
There was a problem hiding this comment.
I think this depends on LTO/all-in-one build, and an API user unlikely to have this advantage.
There was a problem hiding this comment.
You are right. This was not a good idea. I'll remove it.
LaszloLango
force-pushed
the
jerry-api-update
branch
from
e426b86 to
2e9016b
Compare
|
@zherczeg, I've upadted the PR. Please check. |
| * @return true, if invocation was performed successfully, i.e.: | ||
| * - no unhandled exceptions were thrown in connection with the call; | ||
| * false - otherwise. | ||
| * @return TODO |
There was a problem hiding this comment.
sorry, I forgot to update the description.
|
The question is what should happen if we pass error objects as arguments is still open. We definitely need to do something with that before the release. |
LaszloLango
force-pushed
the
jerry-api-update
branch
from
2e9016b to
351ca4c
Compare
|
LGTM |
| NULL, | ||
| args, | ||
| 1); | ||
| if (!jerry_value_is_error (ret_val_print)) |
There was a problem hiding this comment.
ret_val_print should also be released when it's an error, otherwise it may leak.
LaszloLango
force-pushed
the
jerry-api-update
branch
2 times, most recently
from
187b446 to
31ca76b
Compare
|
@dbatyai, I've updated the PR. I will do a big review and update on the function comments in a later PR, but the comments of touched functions should be ready (more or less), so I hope I fixed all of them. :) |
* Fix error handling (related issue: jerryscript-project#1141) * Move output paramters to the end of the arguments lists JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
LaszloLango
force-pushed
the
jerry-api-update
branch
from
31ca76b to
8e85042
Compare
|
LGTM |
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]