Jerry API update #1177

LaszloLango · 2016-06-30T13:02:46Z

No description provided.

zherczeg · 2016-06-30T13:09:32Z

jerry-core/parser/js/js-parser.c

@@ -2265,24 +2264,22 @@ parser_parse_script (const jerry_char_t *source_p, /**< source code */
 * Note:
 *      returned error object should be freed with jerry_release_object
 */
-jsp_status_t
-parser_parse_eval (const jerry_char_t *source_p, /**< source code */
+ecma_object_t *


I would prefer return with an ecma_value_t.

zherczeg · 2016-06-30T13:29:00Z

@poussa and @lemmaa the API update patch is here. Could you give your feedback about the changes in jerry-api.h? Of course you can give feedback for other files as well but since you use the api, we would value your opinion about the API itself.

zherczeg · 2016-06-30T13:31:29Z

jerry-core/jerry-api.h

+                                                  const jerry_value_t);
+
+jerry_value_t jerry_function_call (const jerry_value_t, const jerry_value_t, const jerry_value_t[], jerry_size_t);
+jerry_value_t jerry_object_construct (const jerry_value_t, const jerry_value_t[], jerry_size_t);


I would use function_call and construct_object

poussa · 2016-06-30T14:00:19Z

@jimmy-huang @grgustaf FYI changes coming. PTAL.

tilmannOSG · 2016-07-01T08:39:36Z

@franc0is @HBehrens We would appreciate your feeback on the new API as well :)

grgustaf · 2016-07-01T15:59:32Z

One of @zherczeg 's comments above reminded me, it seems odd that jerry_get_array_length returns uint32_t but [gs]et_array_index_value take jerry_length_t. But I'll admit the myriad aliases for ints confuse me.

Is that as it should be?

poussa · 2016-07-04T07:00:04Z

jerry-core/jerry-api.h


 /**
 * General API functions of JS objects
 */
-bool jerry_is_array (const jerry_object_t *);
-bool jerry_is_constructor (const jerry_object_t *);
-bool jerry_is_function (const jerry_object_t *);


Why are we removing these 3 jerry_is_* functions? How to use the new API to achieve the same functionality?

There are new functions ofr that:

bool jerry_value_is_array (const jerry_value_t);

the point is we don't export the real types of values anymore, all of them are jerry_value_t

zherczeg · 2016-07-05T08:49:26Z

jerry-core/jerry-api.h


 /**
 * Get the global context
 */
-jerry_object_t *jerry_get_global (void);
+jerry_value_t jerry_get_global (void);


I would use jerry_get_global_object since it is not clear that global is an object anymore.

zherczeg · 2016-07-05T09:25:58Z

jerry-core/jerry.c

+  prop_desc_p->is_set_defined = prop_desc.is_set_defined;
+  prop_desc_p->is_value_defined = prop_desc.is_value_defined;
+
+  prop_desc_p->getter = ecma_make_object_value (prop_desc.get_p);


is_getter defined? NULL check?

zherczeg · 2016-07-08T08:44:42Z

docs/03.API-EXAMPLE.md


-Pointers to strings or objects and values should be released just when become unnecessary, using `jerry_release_string` or `jerry_release_object` and `jerry_release_value`, correspondingly.
+JerryScript value can be a boolean, number, null, object, string or undefined. The value has an error flag,
+that indicates whether is an error or not. Every type can be an error not only objects.


Every type has an error flag not only objects.

zherczeg · 2016-07-08T09:57:33Z

I think this is a great job!
LGTM after fixing those small issues.

LaszloLango · 2016-07-08T12:51:15Z

@zherczeg, @dbatyai, I've updated the PR. Please check

dbatyai · 2016-07-08T13:03:42Z

docs/03.API-EXAMPLE.md


-Pointers to strings or objects and values should be released just when become unnecessary, using `jerry_release_string` or `jerry_release_object` and `jerry_release_value`, correspondingly.
+JerryScript value can be a boolean, number, null, object, string or undefined. The value has an error flag,
+that indicates whether is an error or not. Every type has an error flag not only objects.


It should also be noted that the error flag should be cleared before the value is passed as an argument.

And that created error objects automatically have the flag set.

dbatyai · 2016-07-08T13:26:05Z

LGTM otherwise.

* Removed jerry_string_t and jerry_object_t * Updated function names * Updated return values * Updated function descriptions * Added new functions * Added new unittests JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]

jiangzidong · 2016-07-11T07:52:02Z

@LaszloLango Hi, can I assume that it is the API 1.0, and will not change a lot in this period?

zherczeg · 2016-07-11T09:16:38Z

We are hoping this API will be stable. Perhaps we add more functions, but not removing them. Unless something serious comes up. Hopefully not.

jiangzidong · 2016-07-11T11:07:43Z

Thanks! and is our next step is Jerry Port API #964?:)

LaszloLango · 2016-07-11T11:32:32Z

@jiangzidong, yes. Port API patch will be the next :)

LaszloLango added enhancement An improvement api Related to the public API labels Jun 30, 2016

LaszloLango added this to the Release v1.0 milestone Jun 30, 2016

zherczeg reviewed Jun 30, 2016
View reviewed changes

poussa reviewed Jul 4, 2016
View reviewed changes

LaszloLango force-pushed the jerry-api-dev branch from 01abb96 to dba42e0 Compare July 5, 2016 07:25

zherczeg reviewed Jul 5, 2016
View reviewed changes

zherczeg mentioned this pull request Jul 6, 2016

main-unix.c on Ubuntu: jerry_create_external_function assert not reachable (reference error) #1188

Closed

LaszloLango force-pushed the jerry-api-dev branch from 607dbb0 to 5a594dd Compare July 6, 2016 10:42

This was referenced Jul 7, 2016

Jerry API v1.0 #1148

Closed

targets/zephyr: Update to new Jerry API and improve REPL interaction. #1190

Merged

zherczeg reviewed Jul 8, 2016
View reviewed changes

LaszloLango force-pushed the jerry-api-dev branch 2 times, most recently from 79a7a19 to 67147cb Compare July 8, 2016 12:50

dbatyai reviewed Jul 8, 2016
View reviewed changes

LaszloLango force-pushed the jerry-api-dev branch from 67147cb to bc0b7af Compare July 8, 2016 13:58

Update Jerry API

9bce5b0

* Removed jerry_string_t and jerry_object_t * Updated function names * Updated return values * Updated function descriptions * Added new functions * Added new unittests JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]

LaszloLango force-pushed the jerry-api-dev branch from bc0b7af to 9bce5b0 Compare July 11, 2016 07:01

LaszloLango merged commit 9bce5b0 into jerryscript-project:master Jul 11, 2016

LaszloLango mentioned this pull request Jul 11, 2016

Update the API changes in mbed targets #1175

Merged

zherczeg mentioned this pull request Jul 20, 2016

Nominating Dániel Bátyai (dbatyai) for JerryScript Maintainer status #1220

Closed

LaszloLango deleted the jerry-api-dev branch September 1, 2016 12:36

Jerry API update #1177

Jerry API update #1177

Uh oh!

Conversation

LaszloLango commented Jun 30, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zherczeg commented Jun 30, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poussa commented Jun 30, 2016

Uh oh!

tilmannOSG commented Jul 1, 2016

Uh oh!

grgustaf commented Jul 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zherczeg commented Jul 8, 2016

Uh oh!

LaszloLango commented Jul 8, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dbatyai commented Jul 8, 2016

Uh oh!

jiangzidong commented Jul 11, 2016

Uh oh!

zherczeg commented Jul 11, 2016

Uh oh!

jiangzidong commented Jul 11, 2016

Uh oh!

LaszloLango commented Jul 11, 2016

Uh oh!

Uh oh!