Move log level to default port #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
|
Related discussion: #1201 (comment) |
| @@ -32,6 +34,8 @@ extern "C" | |||
| void jerry_port_default_set_abort_on_fail (bool); | |||
| bool jerry_port_default_is_abort_on_fail (void); | |||
|
|
|||
| void jerry_port_default_set_log_level (jerry_log_level_t); | |||
There was a problem hiding this comment.
We have no use case for it but it would be nice to provide a getter as well, as a convenience.
jerry_log_level_t jerry_port_default_get_log_level (void);
|
LGTM |
Setting the log level should be specified by the actual port. JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
LaszloLango
force-pushed
the
move-debug-log-level-to-default-port
branch
from
b052e87 to
f0fd939
Compare
|
@akosthekiss, I've updated the PR. Please check. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the log level should be specified by the actual port.
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]