Build fix for RIOT target after the modifications of the build system… #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -DFEATURE_VALGRIND=OFF \ | ||
| -DCMAKE_TOOLCHAIN_FILE=cmake/toolchain_external.cmake \ | ||
| -DJERRY_LIBC=OFF\ | ||
| -DJERRY_CMDLINE=OFF\ |
There was a problem hiding this comment.
There is need a whitespace, or not?
There was a problem hiding this comment.
Probably optional, but I agree that it looks better with white space.
|
LGTM after the spaces added. |
robertsipka
force-pushed
the
riot_buildfix
branch
from
c34322c to
139027e
Compare
|
Thanks, I've updated the patch. |
| cp `cat $(INTERM)/$(TYPE).external/list` $(OUTPUT)/. | ||
| cp $(OUTPUT)/lib$(TYPE).jerry-core.a $(COPYTARGET)/libjerrycore.a | ||
| make -C$(BUILD_DIR) jerry-core | ||
| cp $(BUILD_DIR)/lib/libjerry-core.a $(COPYTARGET)/libjerrycore.a |
There was a problem hiding this comment.
$(BUILD_DIR) = build/riotstm32f4/ So after the cp command ..//lib/libjerry-core.a ... is it okey?
edit: Ditto at $(COPYTARGET)
There was a problem hiding this comment.
It is, but really ugly, I fixed it, thanks.
robertsipka
force-pushed
the
riot_buildfix
branch
from
139027e to
554f739
Compare
|
LGTM |
… (commit ddab1d8). JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]
robertsipka
force-pushed
the
riot_buildfix
branch
from
554f739 to
e6fefd4
Compare
|
I've rebased it with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (commit ddab1d8).
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]