add ES6 feature: ArrayBuffer #1467
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| /* Copyright JS Foundation and other contributors, http://js.foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "ecma-builtin-helpers.h" | ||
| #include "ecma-builtins.h" | ||
| #include "ecma-exceptions.h" | ||
| #include "ecma-globals.h" | ||
| #include "ecma-helpers.h" | ||
| #include "ecma-objects.h" | ||
| #include "ecma-arraybuffer-object.h" | ||
|
There was a problem hiding this comment. Move this include to the top |
||
| #include "ecma-try-catch-macro.h" | ||
| #include "jrt.h" | ||
| #include "jrt-libc-includes.h" | ||
|
There was a problem hiding this comment. Do we need all of these includes? E.g. ecma-function-object.h ? |
||
|
|
||
| #ifndef CONFIG_DISABLE_ARRAYBUFFER_BUILTIN | ||
|
|
||
| #define ECMA_BUILTINS_INTERNAL | ||
| #include "ecma-builtins-internal.h" | ||
|
|
||
| #define BUILTIN_INC_HEADER_NAME "ecma-builtin-arraybuffer-prototype.inc.h" | ||
| #define BUILTIN_UNDERSCORED_ID arraybuffer_prototype | ||
| #include "ecma-builtin-internal-routines-template.inc.h" | ||
|
|
||
| /** \addtogroup ecma ECMA | ||
| * @{ | ||
| * | ||
| * \addtogroup ecmabuiltins | ||
| * @{ | ||
| * | ||
| * \addtogroup arraybuffer prototype ECMA ArrayBuffer.prototype object built-in | ||
| * @{ | ||
| */ | ||
|
|
||
| /** | ||
| * The ArrayBuffer.prototype.bytelength accessor | ||
| * | ||
| * See also: | ||
| * ES2015, 24.1.4.1 | ||
| * | ||
| * @return ecma value | ||
| * Returned value must be freed with ecma_free_value. | ||
| */ | ||
| static ecma_value_t | ||
| ecma_builtin_arraybuffer_prototype_bytelength_getter (ecma_value_t this_arg) /**< this argument */ | ||
| { | ||
| if (ecma_is_value_object (this_arg)) | ||
| { | ||
| ecma_object_t *object_p = ecma_get_object_from_value (this_arg); | ||
|
|
||
| if (ecma_object_class_is (object_p, LIT_MAGIC_STRING_ARRAY_BUFFER_UL)) | ||
|
There was a problem hiding this comment. Perhaps you could add a newline before this if. Not mandatory id you don't want. |
||
| { | ||
| ecma_length_t len = ecma_arraybuffer_get_length (object_p); | ||
|
|
||
| return ecma_make_uint32_value (len); | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. Delete the newline above, and add a newline after this }. |
||
|
|
||
| return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' is not a ArrayBuffer object.")); | ||
| } /* ecma_builtin_arraybuffer_prototype_bytelength_getter */ | ||
|
|
||
| /** | ||
| * The ArrayBuffer.prototype object's 'slice' routine | ||
| * | ||
| * See also: | ||
| * ES2015, 24.1.4.3 | ||
| * | ||
| * @return ecma value | ||
| * Returned value must be freed with ecma_free_value. | ||
| */ | ||
| static ecma_value_t | ||
| ecma_builtin_arraybuffer_prototype_object_slice (ecma_value_t this_arg, /**< this argument */ | ||
| ecma_value_t arg1, /**< routine's first argument */ | ||
| ecma_value_t arg2) /**< routine's second argument */ | ||
| { | ||
| if (!ecma_is_value_object (this_arg)) | ||
| { | ||
| return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' is not object.")); | ||
| } | ||
|
|
||
| ecma_object_t *object_p = ecma_get_object_from_value (this_arg); | ||
|
|
||
| if (!ecma_object_class_is (object_p, LIT_MAGIC_STRING_ARRAY_BUFFER_UL)) | ||
| { | ||
| return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' is not an ArrayBuffer object.")); | ||
| } | ||
|
|
||
| ecma_length_t len = ecma_arraybuffer_get_length (object_p); | ||
|
|
||
| ecma_length_t start = 0, end = len; | ||
|
|
||
| ecma_value_t ret_value = ecma_make_simple_value (ECMA_SIMPLE_VALUE_EMPTY); | ||
|
|
||
| ECMA_OP_TO_NUMBER_TRY_CATCH (start_num, | ||
| arg1, | ||
| ret_value); | ||
|
|
||
| start = ecma_builtin_helper_array_index_normalize (start_num, len); | ||
|
|
||
| if (!ecma_is_value_undefined (arg2)) | ||
| { | ||
| ECMA_OP_TO_NUMBER_TRY_CATCH (end_num, | ||
| arg2, | ||
| ret_value); | ||
|
|
||
| end = ecma_builtin_helper_array_index_normalize (end_num, len); | ||
|
|
||
| ECMA_OP_TO_NUMBER_FINALIZE (end_num); | ||
| } | ||
|
|
||
| ECMA_OP_TO_NUMBER_FINALIZE (start_num); | ||
|
|
||
| JERRY_ASSERT (start <= len && end <= len); | ||
|
There was a problem hiding this comment. Complie time assert? Shouldn't an error (perhaps rangeerror) be thrown? There was a problem hiding this comment. "start <= len && end <= len" should be ensured by |
||
| ecma_length_t new_len = (end >= start) ? (end - start) : 0; | ||
| ecma_object_t *new_arraybuffer_p = ecma_arraybuffer_new_object (new_len); | ||
| lit_utf8_byte_t *old_buf = ecma_arraybuffer_get_buffer (object_p); | ||
| lit_utf8_byte_t *new_buf = ecma_arraybuffer_get_buffer (new_arraybuffer_p); | ||
|
|
||
| memcpy (new_buf, old_buf + start, new_len); | ||
|
|
||
| return ecma_make_object_value (new_arraybuffer_p); | ||
| } /* ecma_builtin_arraybuffer_prototype_object_slice */ | ||
|
|
||
| /** | ||
| * @} | ||
| * @} | ||
| * @} | ||
| */ | ||
|
|
||
| #endif /* !CONFIG_DISABLE_ARRAYBUFFER_BUILTIN */ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* Copyright JS Foundation and other contributors, http://js.foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef OBJECT_ID | ||
| # define OBJECT_ID(builtin_object_id) | ||
| #endif /* !OBJECT_ID */ | ||
|
|
||
| #ifndef OBJECT_VALUE | ||
| # define OBJECT_VALUE(name, obj_builtin_id, prop_attributes) | ||
| #endif /* !OBJECT_VALUE */ | ||
|
|
||
| #ifndef NUMBER_VALUE | ||
| # define NUMBER_VALUE(name, number_value, prop_attributes) | ||
| #endif /* !NUMBER_VALUE */ | ||
|
|
||
| #ifndef ROUTINE | ||
| # define ROUTINE(name, c_function_name, args_number, length_prop_value) | ||
| #endif /* !ROUTINE */ | ||
|
|
||
| #ifndef ACCESSOR_READ_WRITE | ||
| # define ACCESSOR_READ_WRITE(name, c_getter_func_name, c_setter_func_name, prop_attributes) | ||
| #endif /* !ROUTINE */ | ||
|
|
||
| #ifndef ACCESSOR_READ_ONLY | ||
| # define ACCESSOR_READ_ONLY(name, c_getter_func_name, prop_attributes) | ||
| #endif /* !ACCESSOR_READ_ONLY */ | ||
|
|
||
| /* Object identifier */ | ||
| OBJECT_ID (ECMA_BUILTIN_ID_ARRAYBUFFER_PROTOTYPE) | ||
|
|
||
| /* Object properties: | ||
| * (property name, object pointer getter) */ | ||
|
|
||
| OBJECT_VALUE (LIT_MAGIC_STRING_CONSTRUCTOR, | ||
| ECMA_BUILTIN_ID_ARRAYBUFFER, | ||
| ECMA_PROPERTY_CONFIGURABLE_WRITABLE) | ||
|
|
||
| /* Readonly accessor properties */ | ||
|
There was a problem hiding this comment. This is not strictly a style issue but these comments suggests that ROUTINE properties first, ACCESSOR properties after. This is not true. These lists must follow the property list in the standard because if you execute a for-in loop in JavaScript the names must also follow the same order. |
||
| ACCESSOR_READ_ONLY (LIT_MAGIC_STRING_BYTE_LENGTH_UL, | ||
| ecma_builtin_arraybuffer_prototype_bytelength_getter, | ||
| ECMA_PROPERTY_FIXED) | ||
|
|
||
| /* Routine properties: | ||
| * (property name, C routine name, arguments number or NON_FIXED, value of the routine's length property) */ | ||
| ROUTINE (LIT_MAGIC_STRING_SLICE, ecma_builtin_arraybuffer_prototype_object_slice, 2, 2) | ||
|
|
||
| #undef OBJECT_ID | ||
| #undef SIMPLE_VALUE | ||
| #undef NUMBER_VALUE | ||
| #undef STRING_VALUE | ||
| #undef OBJECT_VALUE | ||
| #undef ROUTINE | ||
| #undef ACCESSOR_READ_WRITE | ||
| #undef ACCESSOR_READ_ONLY | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a built-in array buffer? If not, we can just free the object here. Furthermore we need guards, since array-buffer might be disabled at compile time.