Modify the profile option to specify external compile definitions. #1497
Conversation
robertsipka
force-pushed
the
profile_modes
branch
3 times, most recently
from
2ac536a to
5e9bfe4
Compare
|
|
||
| ### Using profiles with the build system | ||
|
|
||
| You can add profile for the build system in two way: |
There was a problem hiding this comment.
You can specify the profile for the build system in the following ways:
|
|
||
| You can add profile for the build system in two way: | ||
| * with absolute path | ||
| * with a name (in this case the given profile name is assumed in the `profiles` folder) |
There was a problem hiding this comment.
(this options selects profiles/$(name).profile file)
|
|
||
| #### Restrictions | ||
|
|
||
| The profile files can contain comments, but cannot have multi-line compile definitions, and any comma characters. |
There was a problem hiding this comment.
Only single line options are allowed in the profile file. Any line starting with hash-mark is ignored. Semicolon character is not allowed.
|
|
||
| ``` | ||
| # assuming you are in jerryscript folder | ||
| ./tools/build.py --profile=/path/to/profile/my_profile.profile |
There was a problem hiding this comment.
/absolute/path/to/my_profile.any_extension
| ``` | ||
| # assuming you are in jerryscript folder | ||
| ./tools/build.py --profile=minimal | ||
| ``` |
There was a problem hiding this comment.
This command selects the profile/minimal.profile file.
| @@ -0,0 +1 @@ | |||
| # Intentionally empty | |||
|
|
||
| #### 2. Using only CMake build system | ||
|
|
||
| Set the FEATURE_PROFILE compile definition with one of the following values: |
There was a problem hiding this comment.
Set FEATURE_PROFILE option to one of the following values:
robertsipka
force-pushed
the
profile_modes
branch
from
5e9bfe4 to
28e6511
Compare
|
@zherczeg : Thanks! I've modified this patch based on your suggestions. |
|
LGTM |
robertsipka
force-pushed
the
profile_modes
branch
2 times, most recently
from
ed92549 to
e9d26d3
Compare
| @@ -60,7 +63,7 @@ def devhelp(help): | |||
| parser.add_argument('--linker-flag', metavar='OPT', action='append', default=[], help='add custom linker flag') | |||
| parser.add_argument('--lto', metavar='X', choices=['ON', 'OFF'], default='ON', type=str.upper, help='enable link-time optimizations (%(choices)s; default: %(default)s)') | |||
| parser.add_argument('--port-dir', metavar='DIR', action='store', default=DEFAULT_PORT_DIR, help='add port directory (default: %(default)s)') | |||
| parser.add_argument('--profile', metavar='PROFILE', choices=['es5.1', 'minimal', 'es2015-subset'], default='es5.1', type=str.lower, help='specify the profile (%(choices)s; default: %(default)s)') | |||
| parser.add_argument('--profile', metavar='FILE', action='store', default=DEFAULT_PROFILE, help='specify profile file (default: %(default)s)') | |||
There was a problem hiding this comment.
If the directory of profiles is hard coded, then we can set the 'choices' attribute like before.
There was a problem hiding this comment.
It's not hard coded. You can specify the profile file with absolute path, even if it's not in the profiles folder.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]
robertsipka
force-pushed
the
profile_modes
branch
from
e9d26d3 to
3d0010c
Compare
…erryscript-project#1497) JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]
No description provided.