Skip out license-check in case of test262 tests #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
LaszloLango
requested changes
Jan 2, 2017
| @@ -46,7 +46,8 @@ | |||
| ] | |||
|
|
|||
| exclude_dirs = [ | |||
| 'targets/esp8266' | |||
| 'targets/esp8266', | |||
| 'tests/test262', | |||
There was a problem hiding this comment.
It would be better to use TEST262_TEST_SUITE_DIR from settings.py, but it is an absolute path. Should be get a relative path from PROJECT_DIR and TEST262_TEST_SUITE_DIR. @galpeter, can we do it easily in python?
Can break testruns, when the test262 folder already present. JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
bzsolt
force-pushed
the
skip-test262-license-check
branch
from
46f996a to
3e0e353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can break testruns, when the test262 folder already present.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]