Fix old-style function definitions. #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add the |
tilmannOSG
force-pushed
the
fix-old-style-definitions
branch
from
19f0789 to
3d9d51d
Compare
|
@robertsipka Yeah that's a good idea, I've updated the patch accordingly. |
Function definitions with no parameters should always use the void keyword to allow the compiler to catch invalid calls of those functions at compile time. Enable -Wold-style-definition to catch this early in the future. Fixes jerryscript-project#1649. JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller [email protected]
tilmannOSG
force-pushed
the
fix-old-style-definitions
branch
from
3d9d51d to
e99e41c
Compare
|
LGTM (informally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function definitions with no parameters should always use the void keyword to allow the compiler to catch invalid calls of those functions at compile time.
Fixes #1649.
JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller [email protected]