Fix .gitignore syntax #1721
Merged
Fix .gitignore syntax #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d3zd3z the Travis failed on your DCO message. In my opinion you dont need the '<>' bracelets between your email. You can check the log file in the Travis build. |
Change instances of **.ext in the .gitignore to just *.ext. I think the intent was to match these patterns in any directory, which is what will happen with simple patterns. The '**' construct is meant to match zero or more full paths, but it must be the sole component of the path. Discovered by a warning from ripgrep. JerryScript-DCO-1.0-Signed-off-by: David Brown [email protected]
|
Hmm, interesting choice, but ok, I'll fix that. Any idea why we chose a non-standard format for the tag? RFC-2822 is pretty well established, and the regular SoB uses it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change instances of .ext in the .gitignore to just *.ext. I think
the intent was to match these patterns in any directory, which is what
will happen with simple patterns. The '' construct is meant to
match zero or more full paths, but it must be the sole component of
the path.
Discovered by a warning from ripgrep.
JerryScript-DCO-1.0-Signed-off-by: David Brown [email protected]