Merge lit-unicode-*.inc.h-related generator scripts
#1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `conversions` and `ranges` files had separate generators, which shared some functionality through a 3rd python module, and were quite similar to each other -- but also had some differences. Moreover, as they were separate scripts, nothing forced to keep the outputs in sync (to re-generate them at the same time from the same inputs). To fix these maintainability issues, this patch - merges the two python files and part of the 3rd utility module into a single script while keeping the existing functionality, - names the new file `gen-unicode.py` to align better with other generator script in `tools`, and - adds some extra documentation how to retrieve the input files (as they are not part of the repository). The refactoring affected the utility module as well, so this patch also - renames `c_source_helper.py` to `gen_c_source.py` (again, for naming consistency), - reorganizes some of its functions not to export module-local helper functions, and - adapts `js2c.py`, as it also uses this utility module. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
added
enhancement
|
@robertsipka please check this change |
|
I strongly endorse this merge. I also think it is better to keep the outputs in sync. Previously, the version of the inputs were different, but after adapting the generator script of unicode ranges (to python code from bash script), and updating it with the latest version of Unicode Standard, it's not needed to re-generate them from different inputs and scripts anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conversionsandrangesfiles had separate generators, whichshared some functionality through a 3rd python module, and were
quite similar to each other -- but also had some differences.
Moreover, as they were separate scripts, nothing forced to keep the
outputs in sync (to re-generate them at the same time from the same
inputs).
To fix these maintainability issues, this patch
into a single script while keeping the existing functionality,
gen-unicode.pyto align better with othergenerator script in
tools, and(as they are not part of the repository).
The refactoring affected the utility module as well, so this patch
also
c_source_helper.pytogen_c_source.py(again, fornaming consistency),
helper functions, and
js2c.py, as it also uses this utility module.JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]